[receiver/sqlqueryreceiver] Fix tracking results by timestamp column #35195
Conversation
@crobert-1 |
crobert-1
added
the
ready to merge
There was a problem hiding this comment.
Thank you for this fix @Grandys.
I'm only worried that we don't have test coverage for logs tracking for database engines other than PostgreSQL. This means that we're treading in the dark with this feature and changes to it like this valuable fix. As a result, there's a risk that this fix breaks the logs tracking feature for one of the untested engines (e.g. because the RFC3939Nano format is not supported).
I'm supportive of merging this fix, given that the logs stability is currently development. We should have integrations tests for all supported database engines before we move logs support out of development into alpha stability or further.
andrzej-stencel
merged commit 4c6d6a5
into
open-telemetry:main
…pen-telemetry#35195) **Description:** Formats retrieved time columns with milliseconds precision, so they are not reprocessed when used as a tracking_column **Link to tracking Issue:** open-telemetry#35194 **Testing:** Added integration test, updated test data **Documentation:** n/a Closes open-telemetry#35194
Description:
Formats retrieved time columns with milliseconds precision, so they are not reprocessed when used as a tracking_column
Link to tracking Issue: #35194
Testing: Added integration test, updated test data
Documentation: n/a
Closes #35194