-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore]: enable formatter rule from testifylint #35187
Merged
codeboten
merged 1 commit into
open-telemetry:main
from
mmorel-35:testifylint/formatter
Sep 18, 2024
Merged
[chore]: enable formatter rule from testifylint #35187
codeboten
merged 1 commit into
open-telemetry:main
from
mmorel-35:testifylint/formatter
Sep 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorel-35
force-pushed
the
testifylint/formatter
branch
from
September 14, 2024 10:13
a562e66
to
a5d9840
Compare
github-actions
bot
added
exporter/azuredataexplorer
exporter/kafka
exporter/signalfx
exporter/syslog
pkg/stanza
processor/k8sattributes
k8s Attributes processor
receiver/hostmetrics
receiver/prometheus
Prometheus receiver
receiver/signalfx
receiver/splunkhec
labels
Sep 14, 2024
mmorel-35
force-pushed
the
testifylint/formatter
branch
from
September 14, 2024 10:20
a5d9840
to
37be6bc
Compare
mmorel-35
force-pushed
the
testifylint/formatter
branch
from
September 14, 2024 10:27
37be6bc
to
4466ed2
Compare
mmorel-35
requested review from
atoulme,
dmitryax,
dashpole,
fatsheep9146,
TylerHelmuth,
andrzej-stencel,
crobert-1,
MovieStoreGuy,
mx-psi and
codeboten
as code owners
September 14, 2024 10:35
mmorel-35
force-pushed
the
testifylint/formatter
branch
from
September 16, 2024 15:27
4466ed2
to
4b2270a
Compare
crobert-1
approved these changes
Sep 16, 2024
mmorel-35
force-pushed
the
testifylint/formatter
branch
2 times, most recently
from
September 16, 2024 19:12
f80e341
to
b009339
Compare
mmorel-35
force-pushed
the
testifylint/formatter
branch
from
September 16, 2024 19:13
b009339
to
1caafa0
Compare
codeboten
approved these changes
Sep 16, 2024
mmorel-35
force-pushed
the
testifylint/formatter
branch
2 times, most recently
from
September 17, 2024 05:08
3b08eeb
to
4659299
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
mmorel-35
force-pushed
the
testifylint/formatter
branch
from
September 18, 2024 14:31
4659299
to
1d4e870
Compare
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
#### Description Testifylint is a linter that provides best practices with the use of testify. This PR enables [formatter](https://github.com/Antonboom/testifylint?tab=readme-ov-file#formatter) rule from [testifylint](https://github.com/Antonboom/testifylint) Signed-off-by: Matthieu MOREL <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cmd/telemetrygen
telemetrygen command
exporter/azuredataexplorer
exporter/kafka
exporter/signalfx
exporter/syslog
internal/aws
pkg/stanza
processor/k8sattributes
k8s Attributes processor
receiver/hostmetrics
receiver/jmx
JMX Receiver
receiver/prometheus
Prometheus receiver
receiver/signalfx
receiver/splunkhec
receiver/sqlserver
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testifylint is a linter that provides best practices with the use of testify.
This PR enables formatter rule from testifylint