[chore] Fix flakiness of tests on Windows requiring ports in the dynamic range #35061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
…mic range (open-telemetry#35061) **Description:** The need for this was noticed due to the following CI failures on the `receiver/opencensus` lifecycle tests: * https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/10723100311/job/29735640887#step:6:619 * https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/10725662745/job/29744029983#step:6:318 The default port used by the `opencensusreceiver` is in a range that Windows machines can excluded, or reserved to other services via the `WinNAT` service. This change adds a PowerShell script to release the default ports for the `opencensusreceiver` (55678) and the `zpagesextension` (55679) on the Windows GH workflows. While this was affecting only the `opencensusreceiver` at this time, the cost of running this script is small, less than 5s, and later we can easly add other ports if the need arrives. This was already added to the core repo via open-telemetry/opentelemetry-collector#10839 **Link to tracking Issue:** N/A **Testing:** CI **Documentation:** N/A
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…mic range (open-telemetry#35061) **Description:** The need for this was noticed due to the following CI failures on the `receiver/opencensus` lifecycle tests: * https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/10723100311/job/29735640887#step:6:619 * https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/10725662745/job/29744029983#step:6:318 The default port used by the `opencensusreceiver` is in a range that Windows machines can excluded, or reserved to other services via the `WinNAT` service. This change adds a PowerShell script to release the default ports for the `opencensusreceiver` (55678) and the `zpagesextension` (55679) on the Windows GH workflows. While this was affecting only the `opencensusreceiver` at this time, the cost of running this script is small, less than 5s, and later we can easly add other ports if the need arrives. This was already added to the core repo via open-telemetry/opentelemetry-collector#10839 **Link to tracking Issue:** N/A **Testing:** CI **Documentation:** N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The need for this was noticed due to the following CI failures on the
receiver/opencensuslifecycle tests:The default port used by the
opencensusreceiveris in a range that Windows machines can excluded, or reserved to other services via theWinNATservice. This change adds a PowerShell script to release the default ports for theopencensusreceiver(55678) and thezpagesextension(55679) on the Windows GH workflows. While this was affecting only theopencensusreceiverat this time, the cost of running this script is small, less than 5s, and later we can easly add other ports if the need arrives. This was already added to the core repo via open-telemetry/opentelemetry-collector#10839Link to tracking Issue:
N/A
Testing:
CI
Documentation:
N/A