[chore] Fix Supervisor test on Windows #35035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-bradley
requested review from
atoulme and
tigrannajaryan
as code owners
crobert-1
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
LGTM, pending tests passing. Thanks for addressing so quickly @evan-bradley!
It looks like we're being impacted by the |
BinaryFissionGames
approved these changes
Sep 5, 2024
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
Fixes an issue where YAML values need to be carefully quoted or Windows paths are interpreted as escaped values. Also unquote the port number since I think it will be unquoted in most user configs. **Link to tracking Issue:** open-telemetry#35033
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where YAML values need to be carefully quoted or Windows paths are interpreted as escaped values.
Also unquote the port number since I think it will be unquoted in most user configs.
Link to tracking Issue: #35033