-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(otelarrowreceiver): add admission control to otlp path #35021
(otelarrowreceiver): add admission control to otlp path #35021
Conversation
@moh-osman3 I think it will save us and the users some work if we leave a compatibility mode in place for several releases, allowing the former arrow::admission settings to be used. I would do this by leaving copies of the two old fields in the ArrowConfig struct, with the factory defaulting both fields to zero. If during I think this can be done with
|
882447a
to
d398937
Compare
f37593d
to
e7803d1
Compare
Hmm test failing because
|
It looks like this CVE was just published today, it will need resolved in its own PR. It's failing on main, and unrelated to this change. 👍 |
f229730
to
5688eb5
Compare
2877c04
to
c04c5bd
Compare
It's frequency of #35119, unrelated to this change. 👍 |
…tor-contrib into mohosman/admission-for-otlp
…tor-contrib into mohosman/admission-for-otlp
…tor-contrib into mohosman/admission-for-otlp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor comments otherwise LGTM.
Description:
This PR helps memory issues in the standard OTLP data path by sharing the semaphore used for admission control in the arrow data path.