[cmd/opampsupervisor] Add config option for setting the timeout for the initial bootstrap information retrieval from the agent #35000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he initial bootstrap information retrieval from the agent Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
github-actions
bot
requested review from
atoulme,
BinaryFissionGames,
evan-bradley and
tigrannajaryan
Signed-off-by: Florian Bacher <[email protected]>
evan-bradley
approved these changes
Sep 5, 2024
BinaryFissionGames
approved these changes
Sep 17, 2024
|
@bacherfl Can you resolve conflicts on this PR? We can ping Dan to merge once those conflicts are resolved. |
# Conflicts: # cmd/opampsupervisor/supervisor/config/config.go # cmd/opampsupervisor/supervisor/config/config_test.go
Signed-off-by: Florian Bacher <[email protected]>
thanks for the notification @BinaryFissionGames, seems like the merge conflicts went under my radar - they should be fixed now |
|
Sweet, LGTM. @djaglowski Could you merge this once CI passes? |
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…he initial bootstrap information retrieval from the agent (open-telemetry#35000) **Description:** This PR adds a configuration option for setting the timeout for the initial bootstrap information retrieval from the agent. **Link to tracking Issue:** open-telemetry#34996 **Testing:** Added unit tests **Documentation:** Added description for the new option in the specification readme --------- Signed-off-by: Florian Bacher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR adds a configuration option for setting the timeout for the initial bootstrap information retrieval from the agent.
Link to tracking Issue: #34996
Testing: Added unit tests
Documentation: Added description for the new option in the specification readme