-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[processor/k8sattributes] Update README.md #34950
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joegoldman2
requested review from
dmitryax,
fatsheep9146 and
TylerHelmuth
as code owners
September 1, 2024 14:53
songy23
approved these changes
Sep 3, 2024
songy23
added
documentation
Improvements or additions to documentation
Skip Changelog
PRs that do not require a CHANGELOG.md entry
labels
Sep 3, 2024
atoulme
approved these changes
Sep 3, 2024
songy23
added
the
ready to merge
Code review completed; ready to merge by maintainers
label
Sep 4, 2024
TylerHelmuth
reviewed
Sep 5, 2024
TylerHelmuth
removed
the
ready to merge
Code review completed; ready to merge by maintainers
label
Sep 5, 2024
TylerHelmuth
approved these changes
Sep 20, 2024
TylerHelmuth
added
the
ready to merge
Code review completed; ready to merge by maintainers
label
Sep 20, 2024
codeboten
approved these changes
Sep 26, 2024
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
**Documentation:** Update README for Kubernetes Attributes Processor to indicate `container.id` attribute is available if `k8s.container.name` is provided. I followed https://docs.appdynamics.com/observability/cisco-cloud-observability/en/application-performance-monitoring/monitor-applications-in-kubernetes/infrastructure-correlation#InfrastructureCorrelation-KubernetesPodContainerID and it's working. cc @iskiselev --------- Co-authored-by: Alex Boten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
processor/k8sattributes
k8s Attributes processor
ready to merge
Code review completed; ready to merge by maintainers
Skip Changelog
PRs that do not require a CHANGELOG.md entry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to tracking Issue: N/A
Testing: N/A
Documentation:
Update README for Kubernetes Attributes Processor to indicate
container.id
attribute is available ifk8s.container.name
is provided.I followed https://docs.appdynamics.com/observability/cisco-cloud-observability/en/application-performance-monitoring/monitor-applications-in-kubernetes/infrastructure-correlation#InfrastructureCorrelation-KubernetesPodContainerID and it's working.
cc @iskiselev