Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/kafkareceiver] Add otlp_json support in kafka receiver #34840

Merged
merged 14 commits into from
Sep 16, 2024

Conversation

joeyyy09
Copy link
Contributor

@joeyyy09 joeyyy09 commented Aug 26, 2024

Description:

The current features dont support otlp_json in receivers/kafkareceivers.

Add support for otlp_json which accepts json formated for Otel Collector kafka receiver
Link to tracking Issue: #33627

Testing:
Added test files for the same.

Documentation:

@joeyyy09 joeyyy09 changed the title Add otlp_json support in kafka receiver [receiver/kafkareceiver] Add otlp_json support in kafka receiver Aug 26, 2024
@joeyyy09
Copy link
Contributor Author

joeyyy09 commented Aug 26, 2024

this is a draft in process, would love to see if im going in the right direction or not.

receiver/kafkareceiver/unmarshaler.go Outdated Show resolved Hide resolved
receiver/kafkareceiver/README.md Outdated Show resolved Hide resolved
Signed-off-by: joeyyy09 <[email protected]>
@joeyyy09 joeyyy09 marked this pull request as ready for review August 27, 2024 05:02
@joeyyy09 joeyyy09 requested a review from a team August 27, 2024 05:02
Signed-off-by: joeyyy09 <[email protected]>
@yurishkuro
Copy link
Member

@joeyyy09 check the linter failures
kafkareceiver/unmarshaler.go:61: File is not gci-ed with --skip-generated -s standard -s default -s prefix(github.com/open-telemetry/opentelemetry-collector-contrib) (gci)

Signed-off-by: joeyyy09 <[email protected]>
@joeyyy09
Copy link
Contributor Author

joeyyy09 commented Sep 3, 2024

@joeyyy09 check the linter failures kafkareceiver/unmarshaler.go:61: File is not gci-ed with --skip-generated -s standard -s default -s prefix(github.com/open-telemetry/opentelemetry-collector-contrib) (gci)

My bad, fixed that.

receiver/kafkareceiver/README.md Outdated Show resolved Hide resolved
@thmshmm
Copy link
Contributor

thmshmm commented Sep 13, 2024

Support for encoding extensions in the kafkareceiver was just merged with #33888. Using the otlpencodingextension should now do the job.

@yurishkuro
Copy link
Member

Prom tests are failing on main, not an issue here (#35119). Everything else in the PR is green. @open-telemetry/collector-maintainers this can be merged.

@thmshmm I think an upgrade to otlpencodingextension is an independent issue and can be tackled separately, there's no need for it to block this PR.

@mx-psi mx-psi merged commit 01c6651 into open-telemetry:main Sep 16, 2024
155 of 156 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 16, 2024
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this pull request Oct 4, 2024
…n-telemetry#34840)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.

Ex. Adding a feature - Explain what this achieves.-->The current
features dont support otlp_json in receivers/kafkareceivers.
Add support for otlp_json which accepts json formated for Otel Collector
kafka receiver
**Link to tracking Issue:** <Issue number if applicable>  open-telemetry#33627

**Testing:** <Describe what testing was performed and which tests were
added.>
Added test files for the same. 

**Documentation:** <Describe the documentation added.>

---------

Signed-off-by: joeyyy09 <[email protected]>
Co-authored-by: Ziqi Zhao <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants