return concrete types!

[led0nk]

concrete/iface

Description:
As requested this PR removes the unnecessary use of

func (s *azureScraper) getArmClient() (armClient, error) 
func (s *azureScraper) getMetricsDefinitionsClient() (metricsDefinitionsClientInterface, error)
func (s *azureScraper) GetMetricsValuesClient() (metricsValuesClient, error)

Those methods returned interfaces which later got implemented by fields of the *azureScraper.
Now we directly assign them with their concrete types, which were handled through their interfaces before. The implementation of errorhandling was already done earlier.

Link to tracking Issue:

• resolves [receiver/azuremonitor] Return concrete types #31264

Testing:
Testing was done through the given scraper_test.go.

Documentation:

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

[led0nk]

do we solve this in this PR or do we have to raise another one?

[nslaughter]

do we solve this in this PR or do we have to raise another one?

IMO this is a separate issue / PR.

Otherwise, this PR looks great and cleans the code.

[nslaughter]

I have reviewed the deletions and approve providing for checks passing. This PR deletes unnecessary code and replaces usage with essential code.

Filling out the PR comment may be important for getting approvers' review.

[led0nk]

Filling out the PR comment may be important for getting approvers' review.

I will take care of this, thanks

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

[github-actions]

Closed as inactive. Feel free to reopen if this PR is still being worked on.