[receiver/windowseventlog] Add suppress_rendering_info parameter and simplify internal logic. #34720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjanotti
reviewed
Aug 16, 2024
djaglowski
force-pushed
the
wel-supress-rendering-info
branch
from
6c24134
to
c22a815
Compare
djaglowski
commented
Aug 20, 2024
djaglowski
force-pushed
the
wel-supress-rendering-info
branch
2 times, most recently
from
1372b67
to
1560b54
Compare
djaglowski
force-pushed
the
wel-supress-rendering-info
branch
from
edc9933
to
28b81d0
Compare
|
@djaglowski ping me when you think this one is ready (or if you want another pass while still a draft) |
|
Thanks @pjanotti, I'm still just trying to get it to pass CI. There have been a bunch of unrelated tests failing but now it's just https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/10706954934/job/29685874116?pr=34720#step:6:556, which may or may not be related. I don't know if you have any insight on that one but if you do it would be very helpful. |
This was referenced Sep 5, 2024
|
@djaglowski there is something really going on with these tests, when I submitted the PR with the overall changes to the tests I wasn't getting any failure on my machine, but, now it seems almost constant. Nothing conclusive yet but will be looking more deeply into it. |
djaglowski
added a commit
that referenced
this pull request
Sep 13, 2024
I noticed on #34720 and #35026 that execution of the test continued beyond a failure of `require.EventuallyWithT`. Based on the description alone, I would expect that using `assert` within `require.EventuallyWithT` should cause execution to stop if the assertion fails, but it appears this may not be the case. However, this change apparently works as intended.
djaglowski
added a commit
that referenced
this pull request
Sep 20, 2024
This is a step towards #34720 which should have no user facing impact. It consolidates the event model by removing the notion of a "raw" event. The behavior of `raw` flag should remain the same because we still use different functions to build the output from the unified event.
…simplify internal logic.
djaglowski
force-pushed
the
wel-supress-rendering-info
branch
3 times, most recently
from
1570f19
to
f69210b
Compare
djaglowski
force-pushed
the
wel-supress-rendering-info
branch
from
f69210b
to
e4a6b3d
Compare
|
@pjanotti I believe this is ready for a review now |
pjanotti
reviewed
Sep 24, 2024
djaglowski
force-pushed
the
wel-supress-rendering-info
branch
from
f31a247
to
177a7a5
Compare
djaglowski
force-pushed
the
wel-supress-rendering-info
branch
from
177a7a5
to
b53999b
Compare
pjanotti
reviewed
Sep 26, 2024
djaglowski
force-pushed
the
wel-supress-rendering-info
branch
from
180311c
to
8bb2bf5
Compare
pjanotti
approved these changes
Sep 26, 2024
atoulme
approved these changes
Sep 27, 2024
This was referenced Sep 27, 2024
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…y#35032) I noticed on open-telemetry#34720 and open-telemetry#35026 that execution of the test continued beyond a failure of `require.EventuallyWithT`. Based on the description alone, I would expect that using `assert` within `require.EventuallyWithT` should cause execution to stop if the assertion fails, but it appears this may not be the case. However, this change apparently works as intended.
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
This is a step towards open-telemetry#34720 which should have no user facing impact. It consolidates the event model by removing the notion of a "raw" event. The behavior of `raw` flag should remain the same because we still use different functions to build the output from the unified event.
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…simplify internal logic. (open-telemetry#34720) **Description:** This PR contains several changes described in open-telemetry#34131. It does not go as far as breaking out a separate parsing component, but I think it is enough to satisfy the known use cases. - Add `suppress_rendering_info` parameter, which acts orthogonally to `raw` flag. - Remove `RemoteServer` field from `EventXML`. Instead, set `attributes["remote_server"]` if remote collection is used. **Link to tracking Issue:** Resolves open-telemetry#34131
djaglowski
added a commit
that referenced
this pull request
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR contains several changes described in #34131. It does not go as far as breaking out a separate parsing component, but I think it is enough to satisfy the known use cases.
suppress_rendering_infoparameter, which acts orthogonally torawflag.RemoteServerfield fromEventXML. Instead, setattributes["remote_server"]if remote collection is used.Link to tracking Issue:
Resolves #34131