[receiver/googlecloudmonitoringreceiver] Transform GCP Timeseries Data to OTel Metrics Conversion Pipeline #34677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishek-at-cloudwerx
requested review from
dashpole and
TylerHelmuth
as code owners
dashpole
reviewed
Aug 15, 2024
receiver/googlecloudmonitoringreceiver/internal/metrics_conversion.go
Outdated
Show resolved
Hide resolved
receiver/googlecloudmonitoringreceiver/internal/metrics_conversion.go
Outdated
Show resolved
Hide resolved
receiver/googlecloudmonitoringreceiver/internal/metrics_conversion.go
Outdated
Show resolved
Hide resolved
receiver/googlecloudmonitoringreceiver/internal/metrics_conversion.go
Outdated
Show resolved
Hide resolved
dashpole
reviewed
Aug 21, 2024
receiver/googlecloudmonitoringreceiver/internal/metrics_conversion.go
Outdated
Show resolved
Hide resolved
dashpole
reviewed
Aug 21, 2024
dashpole
reviewed
Aug 23, 2024
receiver/googlecloudmonitoringreceiver/internal/metrics_conversion.go
Outdated
Show resolved
Hide resolved
receiver/googlecloudmonitoringreceiver/internal/metrics_conversion.go
Outdated
Show resolved
Hide resolved
dashpole
reviewed
Aug 23, 2024
dashpole
reviewed
Aug 27, 2024
dashpole
approved these changes
Sep 4, 2024
|
@TylerHelmuth this lgtm if you want to take a look |
TylerHelmuth
reviewed
Sep 4, 2024
dashpole
reviewed
Sep 5, 2024
dashpole
reviewed
Sep 5, 2024
|
One other piece of feedback from the Google cloud monitoring team: We should make sure we never query for data more than 24h in the past, as that can cause performance issues for the API. We should either validate that the interval configuration option is less than ~23 hours, or just enforce a max of ~23 hours when we calculate the interval. |
dashpole
reviewed
Sep 5, 2024
dashpole
approved these changes
Sep 5, 2024
TylerHelmuth
approved these changes
Sep 5, 2024
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
…a to OTel Metrics Conversion Pipeline (open-telemetry#34677) **Description:** Transform GCP Timeseries Data to OTel Metrics Pipeline by establishing a client connection to the Google Cloud Monitoring API. This PR scrapes timeseries data based on configured metrics and converts it into the OpenTelemetry format for pipeline processing. **Link to tracking Issue:** open-telemetry#33762 **Testing:** No additional test cases were added. Existing tests cover the necessary functionality. **Documentation:** The **README.md** file was previously added and already includes relevant details about the component and the conversion process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Transform GCP Timeseries Data to OTel Metrics Pipeline by establishing a client connection to the Google Cloud Monitoring API. This PR scrapes timeseries data based on configured metrics and converts it into the OpenTelemetry format for pipeline processing.
Link to tracking Issue: #33762
Testing: No additional test cases were added. Existing tests cover the necessary functionality.
Documentation: The README.md file was previously added and already includes relevant details about the component and the conversion process.