[cmd/telemetrygen] Support boolean values in attributes #34558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Murphy Chen <[email protected]>
mx-psi
reviewed
Aug 9, 2024
| @@ -36,6 +37,12 @@ func (v *KeyValue) Set(s string) error { | |||
| return errFormatOTLPAttributes | |||
| } | |||
| val := kv[1] | |||
| parsedBool, err := strconv.ParseBool(val) | |||
There was a problem hiding this comment.
This accepts also 0 and 1, which is ambiguous (I would expect if I set an attribute to 1 it would be set to the integer 1, not the boolean value true). Could we just parse true and false? Or explicitly exclude 0 and 1
Signed-off-by: Murphy Chen <[email protected]>
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
…ry#34558) **Description:** Support boolean values in attributes **Link to tracking Issue:** Resolves open-telemetry#18928 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> --------- Signed-off-by: Murphy Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Support boolean values in attributes
Link to tracking Issue: Resolves #18928
Testing:
Documentation: