Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pmetrictest] Add comparison options for histograms #34521

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Aug 8, 2024

Description:
pmetrictest panics on some histogram data points when comparing them. This was intended as explicit lack of support.

This PR adds additional code to handle histogram use cases.

@atoulme atoulme requested a review from a team August 8, 2024 16:40
@atoulme atoulme force-pushed the add_compare_for_histograms branch from a03c7e7 to 9fafe01 Compare August 8, 2024 16:42
@atoulme atoulme force-pushed the add_compare_for_histograms branch from 9fafe01 to 1b65cba Compare August 8, 2024 16:47
.chloggen/add_compare_for_histograms.yaml Outdated Show resolved Hide resolved
@dmitryax dmitryax merged commit ad3cc77 into open-telemetry:main Aug 8, 2024
154 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 8, 2024
f7o pushed a commit to f7o/opentelemetry-collector-contrib that referenced this pull request Sep 12, 2024
…4521)

**Description:**
pmetrictest panics on some histogram data points when comparing them.
This was intended as explicit lack of support.

This PR adds additional code to handle histogram use cases.

---------

Co-authored-by: Dmitrii Anoshin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants