Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][cmd/opampsupervisor]: move supervisor start logic into separate Start() function #34509

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Aug 8, 2024

Link to tracking Issue: #34380

@odubajDT odubajDT changed the title [chore]: split NewSupervisor logic into two separate functions [chore][cmd/opampsupervisor]: move supervisor start logic into separate Start() function Aug 8, 2024
@odubajDT odubajDT marked this pull request as ready for review August 8, 2024 09:22
@odubajDT odubajDT requested a review from a team August 8, 2024 09:22
Copy link
Contributor

@BinaryFissionGames BinaryFissionGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on, I've manually tested this and it seems good to me!

Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @odubajDT

@evan-bradley evan-bradley merged commit 98ee06c into open-telemetry:main Aug 8, 2024
156 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 8, 2024
f7o pushed a commit to f7o/opentelemetry-collector-contrib that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants