Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore][processor/transform]: use pmetrictest library for comparing metrics in unit tests #34338

Merged
merged 8 commits into from
Aug 6, 2024
Merged

[chore][processor/transform]: use pmetrictest library for comparing metrics in unit tests #34338

merged 8 commits into from
Aug 6, 2024

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Jul 31, 2024 •
edited
Loading

Description:

Link to tracking Issue: #34297

@github-actions github-actions bot added the processor/transform Transform processor label Jul 31, 2024
@odubajDT odubajDT force-pushed the test-aggregate-fix branch from e18eba1 to 9e3a1f8 Compare July 31, 2024 06:44
@odubajDT odubajDT changed the title [chore]: use reflect.DeepEqual() for map comparison in tests [chore]: order map keys containing datapoints before merging for aggregation Jul 31, 2024
@odubajDT odubajDT marked this pull request as ready for review July 31, 2024 07:17
@odubajDT odubajDT requested a review from a team July 31, 2024 07:17
@odubajDT odubajDT force-pushed the test-aggregate-fix branch from fc08c1a to 097a482 Compare August 1, 2024 07:37
@odubajDT odubajDT changed the title [chore]: order map keys containing datapoints before merging for aggregation [chore]: introduce IgnoreDatapointsOrder into pmetrictest.CompareMetricsOption Aug 1, 2024
@odubajDT
polish
95757f0 
Signed-off-by: odubajDT <[email protected]>
@odubajDT odubajDT force-pushed the test-aggregate-fix branch from 4df9dc1 to 95757f0 Compare August 1, 2024 07:58
odubajDT added 3 commits August 1, 2024 09:59
@odubajDT
go mod tidy
2f58ec8 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
fix lint
7967d2e 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
lint
5a1359e 
Signed-off-by: odubajDT <[email protected]>
@odubajDT odubajDT changed the title [chore]: introduce IgnoreDatapointsOrder into pmetrictest.CompareMetricsOption [chore][pkg/pdatatest]: introduce IgnoreDatapointsOrder into pmetrictest.CompareMetricsOption Aug 1, 2024
evan-bradley
evan-bradley reviewed Aug 1, 2024
View reviewed changes
pkg/pdatatest/pmetrictest/options.go Outdated Show resolved Hide resolved
pkg/pdatatest/pmetrictest/options.go Outdated Show resolved Hide resolved
@odubajDT odubajDT changed the title [chore][pkg/pdatatest]: introduce IgnoreDatapointsOrder into pmetrictest.CompareMetricsOption [pkg/pdatatest]: introduce IgnoreDatapointsOrder into pmetrictest.CompareMetricsOption Aug 2, 2024
@odubajDT
use existing option
dc454bb 
Signed-off-by: odubajDT <[email protected]>
@odubajDT odubajDT changed the title [pkg/pdatatest]: introduce IgnoreDatapointsOrder into pmetrictest.CompareMetricsOption [chore][processor/transform]: use pmetrictest library for comparing metrics in unit tests Aug 2, 2024
@odubajDT
Copy link
Contributor Author

odubajDT commented Aug 6, 2024

@TylerHelmuth can you have a look please ?

@evan-bradley
Copy link
Contributor

@TylerHelmuth This one is pretty minor, so I'm going to merge by ~12:00 EDT unless you have any feedback.

@evan-bradley evan-bradley merged commit e38c3bd into open-telemetry:main Aug 6, 2024
154 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 6, 2024
@odubajDT odubajDT mentioned this pull request Aug 26, 2024
Closed
6 tasks
@crobert-1 crobert-1 mentioned this pull request Sep 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth left review comments

@evan-bradley evan-bradley evan-bradley approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner

@kentquirk kentquirk Awaiting requested review from kentquirk

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

@dashpole dashpole Awaiting requested review from dashpole

@codeboten codeboten Awaiting requested review from codeboten

@dmitryax dmitryax Awaiting requested review from dmitryax

@crobert-1 crobert-1 Awaiting requested review from crobert-1

@atoulme atoulme Awaiting requested review from atoulme

@MovieStoreGuy MovieStoreGuy Awaiting requested review from MovieStoreGuy

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel

@jpkrohling jpkrohling Awaiting requested review from jpkrohling

@fatsheep9146 fatsheep9146 Awaiting requested review from fatsheep9146 fatsheep9146 is a code owner

@mx-psi mx-psi Awaiting requested review from mx-psi

@songy23 songy23 Awaiting requested review from songy23

Assignees

@dashpole dashpole

Labels
cmd/oteltestbedcol connector/count connector/datadog connector/servicegraph exporter/datadog Datadog components exporter/elasticsearch exporter/loadbalancing exporter/opencensus exporter/signalfx internal/core internal/exp/metrics pkg/pdatatest pkg/translator/opencensus pkg/translator/signalfx processor/attributes Attributes processor processor/deltatocumulative processor/geoip processor/interval processor/metricstransform Metrics Transform processor processor/resource Resource processor processor/transform Transform processor receiver/activedirectoryds receiver/aerospike receiver/apache receiver/apachespark receiver/azuremonitor receiver/bigip receiver/collectd receiver/couchdb receiver/dockerstats receiver/elasticsearch receiver/expvar receiver/filestats receiver/flinkmetrics receiver/gitprovider receiver/haproxy receiver/hostmetrics receiver/httpcheck HTTP Check receiver receiver/iis receiver/jmx JMX Receiver receiver/k8scluster receiver/kubeletstats receiver/memcached receiver/mongodb receiver/mysql receiver/nginx receiver/nsxt NSXT Receiver receiver/opencensus receiver/postgresql receiver/rabbitmq
Projects
None yet
Milestone
v0.107.0
Development

Successfully merging this pull request may close these issues.
4 participants
@odubajDT @evan-bradley @TylerHelmuth @dashpole