Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support aws plugins EC2/ECS/Beanstalk #343

Merged
merged 4 commits into from
Jun 22, 2020
Merged

support aws plugins EC2/ECS/Beanstalk #343

merged 4 commits into from
Jun 22, 2020

Conversation

wangzlei
Copy link
Contributor

Description: Add AWS EC2/ECS/Beanstack resources support

Link to tracking Issue:

Testing: Verified in https://github.com/aws-samples/aws-xray-sdk-with-opentelemetry-sample/tree/both-otel-and-xray
Can get AWS service resources in Span.

Documentation: https://docs.aws.amazon.com/xray/latest/devguide/xray-sdk-java-configuration.html#xray-sdk-java-configuration-plugins

@wangzlei wangzlei requested a review from a team June 18, 2020 21:34
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 18, 2020

CLA Check
The committers are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #343 into master will decrease coverage by 0.00%.
The diff coverage is 85.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #343      +/-   ##
==========================================
- Coverage   82.60%   82.59%   -0.01%     
==========================================
  Files         170      170              
  Lines        9049     9063      +14     
==========================================
+ Hits         7475     7486      +11     
- Misses       1249     1251       +2     
- Partials      325      326       +1     
Flag Coverage Δ
#integration 0.00% <ø> (ø)
#unit 82.59% <85.00%> (-0.01%) ⬇️
Impacted Files Coverage Δ
exporter/awsxrayexporter/translator/segment.go 92.25% <62.50%> (-1.86%) ⬇️
exporter/awsxrayexporter/translator/aws.go 96.03% <100.00%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb734dc...5a44fee. Read the comment docs.

@tigrannajaryan tigrannajaryan merged commit 0fba66a into open-telemetry:master Jun 22, 2020
codeboten pushed a commit that referenced this pull request Nov 23, 2022
Based on the OpenCensus agent exporter.

Fixes #343

Co-authored-by: Chris Kleinknecht <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants