-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature-gate to delete original time field from parsed container logs #33946
Add feature-gate to delete original time field from parsed container logs #33946
Conversation
cfe7005
to
7e9d93b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A feature gate seems a little excessive here because the operator is very new and the information being deleted is available in a more helpful form elsewhere on the log. I'm fine with leaving it if you prefer but also ok with simplifying.
I'm in two minds about the feature gate :). My only concern is about potentially breaking the Helm preset which switched to the If we agree on this I'm happy to remove the feature gate and land it with the direct deletion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a small comment
@@ -78,6 +88,14 @@ func (c Config) Build(set component.TelemetrySettings) (operator.Operator, error | |||
} | |||
} | |||
|
|||
if removeOriginalTimeField.IsEnabled() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we log this message when not using the feature gate instead? That way would make the user that is not using the gate, aware of the future removal.
if removeOriginalTimeField.IsEnabled() { | |
if !removeOriginalTimeField.IsEnabled() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, that was the intention since the gate will be initially in StageAlpha
.
Thank's for catching this!
change_type: 'enhancement' | ||
|
||
# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver) | ||
component: pkg/stanza |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably more meaningful for users if we set the component to receiver/filelog
? Especially that the feature gate has filelog
in its name.
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Co-authored-by: Andrzej Stencel <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
8bfb9ee
to
9e73b78
Compare
Description:
This PR adds support for removing the original
time
attribute/field from the parsed log record as it was suggested at #33389.Users should use the
Timestamp
field which holds the parsed time.This patch introduces this change behind a feature flag called
filelog.container.removeOriginalTimeField
which is disabled by default following the feature lifecycle.Link to tracking Issue: #33389
Testing:
./bin/otelcontribcol_linux_amd64 --config container_config.yaml --feature-gates=filelog.container.removeOriginalTimeField
and verify the output:Documentation: Added.