[pkg/ottl] Add Decode function
#33942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
github-actions
bot
requested review from
bogdandrutu,
evan-bradley,
kentquirk and
TylerHelmuth
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
# Conflicts: # pkg/ottl/go.mod
Signed-off-by: Florian Bacher <[email protected]>
# Conflicts: # pkg/ottl/go.mod
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
pkg/ottl/ottlfuncs/README.md
Outdated
There was a problem hiding this comment.
We should mark base64decode as deprecated and link to decode in this doc.
There was a problem hiding this comment.
good point - i added a deprecation notice to the base64decode function
Signed-off-by: Florian Bacher <[email protected]>
# Conflicts: # pkg/ottl/go.mod # pkg/ottl/go.sum
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
|
@evan-bradley @TylerHelmuth this one should be ready for another review now |
# Conflicts: # pkg/ottl/go.mod
Signed-off-by: Florian Bacher <[email protected]>
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
# Conflicts: # pkg/ottl/go.mod
# Conflicts: # pkg/ottl/go.mod
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
djaglowski
approved these changes
Sep 4, 2024
TylerHelmuth
approved these changes
Sep 5, 2024
evan-bradley
pushed a commit
that referenced
this pull request
Sep 5, 2024
**Description:** Follow up to #33942. I'd like to share the exact override key strings so that they don't get out of sync. Maybe this is too much effort, but wanted to discuss It looks like there is some more reuse between textutils and stanza, but that could be done in a separate PR.
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
**Description:** This PR adds a `Decode` function that accepts a string or byte array, and a encoding name as an input and transforms it to UTF-8 **Link to tracking Issue:** open-telemetry#32493 **Testing:** Added unit and e2e tests **Documentation:** Added an entry in the readme to describe the new function --------- Signed-off-by: Florian Bacher <[email protected]> Co-authored-by: Daniel Jaglowski <[email protected]>
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
**Description:** Follow up to open-telemetry#33942. I'd like to share the exact override key strings so that they don't get out of sync. Maybe this is too much effort, but wanted to discuss It looks like there is some more reuse between textutils and stanza, but that could be done in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR adds a
Decodefunction that accepts a string or byte array, and a encoding name as an input and transforms it to UTF-8Link to tracking Issue: #32493
Testing: Added unit and e2e tests
Documentation: Added an entry in the readme to describe the new function