Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Sending Queue Option for OpenSearch #33919

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jynolen
Copy link

@jynolen jynolen commented Jul 4, 2024

Description:
Add Sending Queue to enable persistent queue in case of upstream failure

Documentation:
Add the options in the exporter README

Copy link

linux-foundation-easycla bot commented Jul 4, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: jynolen / name: Jean-Yves NOLEN (a529f61)

@jynolen jynolen force-pushed the feature/opensearch-sending-queue branch from 0700945 to 322436a Compare July 4, 2024 12:24
@jynolen jynolen marked this pull request as ready for review July 4, 2024 12:26
@jynolen jynolen requested review from a team and codeboten July 4, 2024 12:26
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jul 19, 2024
@jynolen
Copy link
Author

jynolen commented Jul 19, 2024

Not stale, @codeboten could you have a look ? Thanks 👍

@github-actions github-actions bot removed the Stale label Jul 20, 2024
Copy link
Contributor

github-actions bot commented Aug 4, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Aug 4, 2024
@jynolen
Copy link
Author

jynolen commented Aug 4, 2024

Not stale, can someone review this PR to make it merge ?

@github-actions github-actions bot removed the Stale label Aug 5, 2024
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Aug 28, 2024
@jynolen
Copy link
Author

jynolen commented Aug 28, 2024 via email

@github-actions github-actions bot removed the Stale label Aug 29, 2024
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Sep 12, 2024
@jynolen
Copy link
Author

jynolen commented Sep 12, 2024 via email

@github-actions github-actions bot removed the Stale label Sep 13, 2024
@chikei
Copy link

chikei commented Sep 30, 2024

I think codes owner for this component are: @Aneurysm9 @MitchellGale @MaxKsyunz @YANG-DB
Could you take a look please ?

Copy link
Contributor

@MaxKsyunz MaxKsyunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atoulme
Copy link
Contributor

atoulme commented Oct 14, 2024

the changes look good to me, can a codeowner take a look?

@jynolen jynolen requested a review from a team as a code owner October 22, 2024 10:03
@jynolen jynolen force-pushed the feature/opensearch-sending-queue branch from dedfa50 to 10ae156 Compare October 22, 2024 10:28
@jynolen
Copy link
Author

jynolen commented Oct 22, 2024

I sync with main and made options name change because of depreciation

@jynolen jynolen force-pushed the feature/opensearch-sending-queue branch from 10ae156 to a529f61 Compare October 22, 2024 16:13
@jynolen
Copy link
Author

jynolen commented Oct 25, 2024

the changes look good to me, can a codeowner take a look?

I know people busy but TBH 4 month for a 4line changes, it's a bit long.

@MitchellGale
Copy link
Contributor

Change looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants