-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics transform processor README #339
Conversation
Codecov Report
@@ Coverage Diff @@
## master #339 +/- ##
=======================================
Coverage 83.38% 83.38%
=======================================
Files 167 167
Lines 8943 8943
=======================================
Hits 7457 7457
Misses 1161 1161
Partials 325 325 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from my perspective.
Does this add documentation for a processor that does not exist in this repo yet? |
@tigrannajaryan This adds documentation and establishes a space for an incoming processor that is still in progress. As suggested by @bogdandrutu from a meeting, initializing a space with a README first would be a good first step. |
Hi @asuresh4 , I am a Google intern currently working on this project (issue proposal), and I see that you are assigned to this Pull Request. Since I am not seeing many activities here, do you think you could merge this anytime soon, and after that, my subsequent Pull Request will also come into this folder for this metrics transform processor. |
|
||
## Examples | ||
|
||
### Insert New Metric |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would the config look like if I'd like to rename more than one metric? I maybe missing the context, but it appears to me like one can only operate on a single metric per processor config. Is that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, it was actually a bit out of date. I just updated the new version, which has a transforms
field that accepts a list, which can be used to transform more than one metric.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that your other PR is quite far along, I recommend you just incorporate this README into your other PR and close this one. We can merge this together with the implementation once that's ready
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea that works too!
README moved to other PR: #347 |
Approved by admins: open-telemetry/community#172
Bumps [go.uber.org/zap](https://github.com/uber-go/zap) from 1.19.1 to 1.20.0. - [Release notes](https://github.com/uber-go/zap/releases) - [Changelog](https://github.com/uber-go/zap/blob/master/CHANGELOG.md) - [Commits](uber-go/zap@v1.19.1...v1.20.0) --- updated-dependencies: - dependency-name: go.uber.org/zap dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Description: README for the metrics transform processor
Link to tracking Issue: #332 (comment)
Documentation: preview is available here: https://github.com/JingboWangGoogle/opentelemetry-collector-contrib/tree/readme/processor/metricstransformprocessor