[chore] Fix more load test pipeline issues #33885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
mowies
changed the title
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
mx-psi
reviewed
Jul 4, 2024
|
Can we add an issue to track adding
back? |
mx-psi
approved these changes
Jul 4, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes more issues with the load test pipeline. Specifically, it adjusts some things around artifact up/download which is needed as a result of the breaking changes in GitHub Actions artifacts listed here.
Also, it removes the issue generation step which seems far outdated as it's failing with missing CircleCI env variables.
Also, I noticed that a few of the load tests fail consistently. To test. the pipeline, I had to comment them out. Not sure, what to do with them...
Link to tracking Issue:
Part of #33577
Follow up to #33860
Testing: Testing done on my personal fork. Link to working pipeline run:
Green run with some broken tests commented out, but pipeline working
Red run with broken tests
Documentation: none added