[exporter/awsxray] Allow multiple log group names/arns to be set in environmental variables #33795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangzlei
approved these changes
Jun 27, 2024
srprash
approved these changes
Jun 27, 2024
andrzej-stencel
approved these changes
Jun 28, 2024
|
@dashpole or @andrzej-stencel Could you help to merge the change? Thank you! |
songy23
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Cherry-picking from downstream:
amazon-contributing#218
&to separate individual log group name or arn because & is not allowed in log group names (https://docs.aws.amazon.com/AmazonCloudWatchLogs/latest/APIReference/API_CreateLogGroup.html) and&implicitly means 'AND'.Link to tracking Issue:
N/A
Testing:
Unit Testing
Documentation:
The readme for xray exporter is updated.