-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster json parser #33785
Faster json parser #33785
Conversation
7da7609
to
fb7a764
Compare
fb7a764
to
a649883
Compare
a649883
to
ce895d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, it looks like the https://github.com/json-iterator/go that is currently used has been unmaintained for about 2 years now? @atoulme are you aware of other major open source projects using the proposed library https://github.com/goccy/go-json? |
ce895d3
to
81e1d52
Compare
Following a few of those paths, it seems to be used by datadog libraries and the Go arrow client. Given that json-iterator/go is not seeing any updates for 2 years, jumping to another lib with minimal change to the functional set seems like the right idea. |
…33929) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #33785 switched the library for the `json` parser. Based on this, we should switch the library for the `container` parser as well. (No benchmarks were added since we can rely on those of #33785 I guess. Happy to add some if it's suggested though) **Link to tracking Issue:** <Issue number if applicable> **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> Signed-off-by: ChrsMark <[email protected]>
This follows #33785 by switching to a faster json library.
This follows open-telemetry#33785 by switching to a faster json library.
Description:
Switch libraries to reduce the footprint of the JSON parser.
Link to tracking Issue:
Fixes #33784
Testing:
Before:
After:
Benchstat: