Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[procesor/groupbyattrsprocessor]: fix droping metadata when processing metrics #33781

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Jun 26, 2024

Description:
Fixes the metadata dropping when processing metrics

Link to tracking Issue: #33419

Testing:

  • unit tests

@github-actions github-actions bot added the processor/groupbyattrs Group By Attributes processor label Jun 26, 2024
@github-actions github-actions bot requested a review from rnishtala-sumo June 26, 2024 13:26
@odubajDT odubajDT changed the title [procesor/groupbyattrsprocessor]: fix droping metadata when copying metrics [procesor/groupbyattrsprocessor]: fix droping metadata when processing metrics Jun 27, 2024
@odubajDT odubajDT force-pushed the fix-metrics-metadata branch from c7ca9cb to 7766cee Compare June 27, 2024 06:39
@odubajDT odubajDT marked this pull request as ready for review June 27, 2024 06:39
@odubajDT odubajDT requested review from a team and fatsheep9146 June 27, 2024 06:39
Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@evan-bradley
Copy link
Contributor

@rnishtala-sumo could you take a look as the code owner of this component?

@rnishtala-sumo
Copy link
Contributor

minor nit, LGTM otherwise.

@odubajDT odubajDT force-pushed the fix-metrics-metadata branch 2 times, most recently from 04dc281 to df57a54 Compare July 2, 2024 07:04
@odubajDT odubajDT force-pushed the fix-metrics-metadata branch from 9184af2 to 377714c Compare July 15, 2024 05:10
@evan-bradley evan-bradley merged commit a078f7a into open-telemetry:main Jul 15, 2024
154 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
processor/groupbyattrs Group By Attributes processor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants