[exporter/elasticsearch] deprecate 'dedup' config #33779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codefromthecrypt
approved these changes
Jun 27, 2024
| # (Optional) One or more lines of additional information to render under the primary note. | ||
| # These lines will be padded with 2 spaces and then inserted directly into the document. | ||
| # Use pipe (|) for multiline entries. | ||
| subtext: |
There was a problem hiding this comment.
Suggested change
| subtext: | |
| subtext: dedot has been deprecated, and will always be enabled in ECS mode in future |
There was a problem hiding this comment.
almost, the other PR is for dedot :) adapted, thanks
axw
commented
Jun 27, 2024
| # (Optional) One or more lines of additional information to render under the primary note. | ||
| # These lines will be padded with 2 spaces and then inserted directly into the document. | ||
| # Use pipe (|) for multiline entries. | ||
| subtext: |
There was a problem hiding this comment.
almost, the other PR is for dedot :) adapted, thanks
codefromthecrypt
approved these changes
Jun 27, 2024
codefromthecrypt
approved these changes
Jun 28, 2024
carsonip
approved these changes
Jun 28, 2024
andrzej-stencel
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Deprecate
exporter/elasticsearch's "dedup" configuration. In a future release we will remove this configuration, and always deduplicate wherever necessary.Link to tracking Issue:
#33773
Testing:
N/A
Documentation:
Updated the README.