[processor/metricstransformprocessor]: Support median aggregation type #33655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal/core
processor/metricstransform
odubajDT
force-pushed
the
aggregation-metricstransformprocessor
branch
2 times, most recently
from
4d0ee19 to
33c5372
Compare
odubajDT
changed the title
odubajDT
force-pushed
the
aggregation-metricstransformprocessor
branch
from
268ed54 to
8eabf28
Compare
evan-bradley
pushed a commit
that referenced
this pull request
Jul 2, 2024
**Description:** <Describe what has changed.> - duplicated and enhanced aggregation business logic (with median function) for common usage in follow-up tickets - tests **Link to tracking Issue:** #16224 **Follow-ups:** - #33655 - #33334 - #33423 --------- Signed-off-by: odubajDT <[email protected]>
odubajDT
force-pushed
the
aggregation-metricstransformprocessor
branch
2 times, most recently
from
def6d9f to
451b941
Compare
odubajDT
force-pushed
the
aggregation-metricstransformprocessor
branch
2 times, most recently
from
ac49460 to
88b7084
Compare
evan-bradley
approved these changes
Jul 10, 2024
processor/metricstransformprocessor/metrics_transform_processor_otlp.go
Outdated
Show resolved
Hide resolved
|
@dmitryax Could you take a look? This bridges what I believe is the final gap between the metrics transform processor and transform processor, and will let us confidently merge #33334. I'll do a review after this to confirm, but I think once we know there is parity between the two, we can start pointing users to the transform processor as a meaningful replacement. |
odubajDT
force-pushed
the
aggregation-metricstransformprocessor
branch
2 times, most recently
from
9587143 to
a97a4c2
Compare
Signed-off-by: odubajDT <[email protected]>
…r_otlp.go Co-authored-by: Evan Bradley <[email protected]>
odubajDT
force-pushed
the
aggregation-metricstransformprocessor
branch
from
a97a4c2 to
e9a6f45
Compare
6 tasks
TylerHelmuth
added a commit
that referenced
this pull request
Oct 11, 2024
**Description:** <Describe what has changed.> It is a valid use case to aggregate against an empty label set, which will functionally clear all attributes. This behaviour was removed in #33655, which simplified the check to `len() == 0`, which covers the case of the label set being `nil` and having 0 elements as the same scenario. However, these are not the same scenario and have different meanings. This PR reintroduces the original behaviour, but in a more efficient way by recognizing a label set with 0 elements and clearing the attributes, which would be the logical conclusion after running the filter anyway. **Link to tracking Issue:** #34430 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> --------- Co-authored-by: Tyler Helmuth <[email protected]>
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…metry#35006) **Description:** <Describe what has changed.> It is a valid use case to aggregate against an empty label set, which will functionally clear all attributes. This behaviour was removed in open-telemetry#33655, which simplified the check to `len() == 0`, which covers the case of the label set being `nil` and having 0 elements as the same scenario. However, these are not the same scenario and have different meanings. This PR reintroduces the original behaviour, but in a more efficient way by recognizing a label set with 0 elements and clearing the attributes, which would be the logical conclusion after running the filter anyway. **Link to tracking Issue:** open-telemetry#34430 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> --------- Co-authored-by: Tyler Helmuth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
interval/coremedianaggregation typeLink to tracking Issue: #16224
Depends on #33669