[receiver/prometheusreceiver] Fix retrieval of aggregated metrics with no job/instance label #33565
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR fixes the retrieval of metrics where either the
job
orinstance
label is missing, andhonor_labels
is set totrue
. This can be the case for aggregated metrics coming from a federate endpoint. This PR introduces a fallback to using thejob
/instance
labels from the scrape config for such metrics.Link to tracking Issue: Fixes #32555
Testing:
This was tested on a
kind
K8s cluster running the prometheus operator, with a port forward for theprometheus-k8s
service created by the prometheus operator (therefore thelocalhost:9090
address in the target).