AWSPrometheusRemoteWriteExporter - Add SDK and system information to User-Agent header #3317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requesting reviews from @Aneurysm9 @anuraaga |
Aneurysm9
approved these changes
May 4, 2021
anuraaga
reviewed
May 5, 2021
|
@dhruv-vora please address @anuraaga feedback |
anuraaga
reviewed
May 6, 2021
| @@ -16,6 +16,7 @@ package awsprometheusremotewriteexporter | |||
|
|
|||
There was a problem hiding this comment.
If I'm not mistaken we don't have a test verifying the user agent (it would be some sort of fuzzy match I guess)
There was a problem hiding this comment.
I have modified the tests to add verification of the user-agent header
anuraaga
reviewed
May 6, 2021
anuraaga
approved these changes
May 6, 2021
|
Please rebase to be able to pass one test that uses expired certificates and was fixed |
Aneurysm9
approved these changes
May 7, 2021
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In order to better understand usage patterns for the AWS Prometheus Remote Write exporter in the Collector, we’re adding SDK and system information in the request header.