[chore][exporter/elasticsearch] Add benchmark for traces consumer #33087
Conversation
- Updates the mock Elasticsearch data receiver to handle traces. - Adds an extra metric to report events per second.
| return err | ||
| return fmt.Errorf("failed to create logs receiver: %w", err) | ||
| } | ||
| es.receiver, err = factory.CreateTracesReceiver(context.Background(), set, cfg, tc) |
There was a problem hiding this comment.
This is overwriting es.receiver which is a receiver.Logs. Is this intended?
There was a problem hiding this comment.
Yeah, both will be same since we use SharedComponent
There was a problem hiding this comment.
It might have been a source of confusion for others so I added a comment and assertion (overkill maybe? - feedbacks welcomed) to check if they point to the same object.
|
[For reviewers] In order to reduce the impact of decoding bulk requests in the mock receiver I have removed the correctness checks from the benchmarks. The benchmarks now don't decode bulk requests and rely on the correctness to be tested in other tests. This gives us a better benchmark result. Note that if |
|
Looking good! Here are the results from my machine: $ cd exporter/elasticsearchexporter/integrationtest
$ go test -bench=BenchmarkExporter -run=^$ ./...
goos: linux
goarch: amd64
pkg: github.com/open-telemetry/opentelemetry-collector-contrib/exporter/elasticsearchexporter/integrationtest
cpu: 13th Gen Intel(R) Core(TM) i7-13700H
BenchmarkExporter/logs/small_batch-20 10000 219200 ns/op 45620 events/s 65539 B/op 355 allocs/op
BenchmarkExporter/logs/medium_batch-20 554 2009038 ns/op 49775 events/s 643463 B/op 3450 allocs/op
BenchmarkExporter/logs/large_batch-20 56 21210056 ns/op 47147 events/s 6430709 B/op 34416 allocs/op
BenchmarkExporter/logs/xlarge_batch-20 6 191364099 ns/op 52256 events/s 63892213 B/op 343340 allocs/op
BenchmarkExporter/traces/small_batch-20 5449 247561 ns/op 40394 events/s 67422 B/op 396 allocs/op
BenchmarkExporter/traces/medium_batch-20 506 2096840 ns/op 47691 events/s 661824 B/op 3853 allocs/op
BenchmarkExporter/traces/large_batch-20 54 19818097 ns/op 50459 events/s 6585914 B/op 38418 allocs/op
BenchmarkExporter/traces/xlarge_batch-20 5 235706998 ns/op 42426 events/s 65868492 B/op 384351 allocs/op
PASS
ok github.com/open-telemetry/opentelemetry-collector-contrib/exporter/elasticsearchexporter/integrationtest 21.859s |
Description: Similar to #33035 the PR adds benchmarks for
ConsumeTraces.The PR also updates the mock es receiver to handle
tracesproperly in order to have better readability of the tests/benchmarks and avoid confusion with the special handling -- this is done by using separate index configuration for traces and logs to distinguish the items in the bulk indexer payload. The PR also adds an extra metric to the benchmarks (Consume{Traces, Logs}) for reporting events consumed per second.Link to tracking Issue: 32504
Testing:
cd exporter/elasticsearchexporter/integrationtest && go test -bench=BenchmarkExporter -run=^$ ./...Documentation: N/A