Modify comments on default configs to accurately reflect the defaults. #32936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for catching these incorrect comments! Wanted to confirm that the receiver otherwise works as expected |
crobert-1
approved these changes
May 8, 2024
shalper2
approved these changes
May 8, 2024
|
@shalper2 I only did a really basic POC with it, but it did in fact log the HTTP POST's body to the debug exporter as expected, so yes as far as I've attempted to use it! |
songy23
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Some of the comments related to the defaults for the webhookeventreceiver were incorrect. I was looking through the code trying to make it work in an attempt to try this receiver and I was thrown off by references to different things being the default in different places.
Link to tracking Issue:
Testing:
No code changes, comments only change.
Documentation:
Comments were changed to be accurate.