-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(s3exporter/config-validation): endpoint should contain region and S3 bucket #32815
fix(s3exporter/config-validation): endpoint should contain region and S3 bucket #32815
Conversation
…ion and S3 bucket
Actually I am not sure what protocol |
cc @atoulme @pdelewski. |
Yes, I guess so. |
@bogdandrutu anything else I should do in order to merge this? |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
@open-telemetry/collector-contrib-maintainer if anyone has a chance to take another look at this PR before it gets marked as stale again, that'd be great, thanks. |
@dabcoder PTAL at the failing tests |
Thanks @dmitryax. They should be fixed now, I ran the tests locally and they're passing. |
Description:
Discussion: #32766.
Link to tracking Issue: #32774
Testing: added test cases to validate config when endpoint is provided.
Documentation: updated README.
Configuration logic:
Tasks: