Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3exporter/config-validation): endpoint should contain region and S3 bucket #32815

Merged

Conversation

dabcoder
Copy link
Contributor

@dabcoder dabcoder commented May 2, 2024

Description:

Discussion: #32766.

Link to tracking Issue: #32774

Testing: added test cases to validate config when endpoint is provided.

Documentation: updated README.

Configuration logic:

  • An endpoint is provided, and Region still needs to be provided (as per the AWS SDK Go config, even though the region can be included in the endpoint itself). The S3 bucket name is optional.
  • An endpoint is not provided, thus region and S3 bucket name should be provided (return an error for each if one of those 2 isn't)

Tasks:

  • Add entry to changelog
  • Edit the docs

Copy link

linux-foundation-easycla bot commented May 2, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@dabcoder dabcoder marked this pull request as ready for review May 2, 2024 13:25
@dabcoder dabcoder requested a review from a team May 2, 2024 13:25
@dabcoder
Copy link
Contributor Author

dabcoder commented May 3, 2024

Actually I am not sure what protocol endpoint should use. I am seeing unsupported protocol scheme \"s3\""} errors in logs when using an endpoint starting with s3://, so we may also need to clarify that this support http(s) only?

@dabcoder
Copy link
Contributor Author

dabcoder commented May 7, 2024

cc @atoulme @pdelewski.

@atoulme
Copy link
Contributor

atoulme commented May 7, 2024

Actually I am not sure what protocol endpoint should use. I am seeing unsupported protocol scheme \"s3\""} errors in logs when using an endpoint starting with s3://, so we may also need to clarify that this support http(s) only?

Yes, I guess so.

@dabcoder
Copy link
Contributor Author

@bogdandrutu anything else I should do in order to merge this?

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added Stale and removed Stale labels May 29, 2024
@dabcoder
Copy link
Contributor Author

@open-telemetry/collector-contrib-maintainer if anyone has a chance to take another look at this PR before it gets marked as stale again, that'd be great, thanks.

@dmitryax
Copy link
Member

dmitryax commented Jun 9, 2024

@dabcoder PTAL at the failing tests

@dabcoder
Copy link
Contributor Author

Thanks @dmitryax. They should be fixed now, I ran the tests locally and they're passing.

@dmitryax dmitryax merged commit 8cf80e7 into open-telemetry:main Jun 11, 2024
162 checks passed
@github-actions github-actions bot added this to the next release milestone Jun 11, 2024
@dabcoder dabcoder deleted the daboucha/s3exporter/config-validation branch June 13, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants