Adds suggestions for monitoring and tuning the tail sampling processor to the README #32728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swar8080
commented
Apr 28, 2024
swar8080
commented
Apr 28, 2024
tiffany76
reviewed
Apr 30, 2024
Thanks @tiffany76 |
jpkrohling
reviewed
May 7, 2024
| This measures latency of sampling a batch of traces and passing sampled traces through the remainder of the collector pipeline. A latency exceeding 1 second can delay sampling decisions beyond `decision_wait`, increasing the chance of traces being dropped before sampling. | ||
|
|
||
| It's therefore recommended to consume this component's output with components that trigger an asynchronous or fast export, like the `batch` processor. |
There was a problem hiding this comment.
I wonder if we should name the batch processor specifically, given we know we'll deprecate it in favor of native batching on exporters.
There was a problem hiding this comment.
good to know, it no longer mentions batch processor specifically, just fast/asynchronous consumers in general
Co-authored-by: Tiffany Hrabusa <[email protected]>
Co-authored-by: Tiffany Hrabusa <[email protected]>
Co-authored-by: Tiffany Hrabusa <[email protected]>
Co-authored-by: Tiffany Hrabusa <[email protected]>
…ch processor to avoid delayed sampling decisions
swar8080
force-pushed
the
tail_sampling_monitoring_readme
branch
from
2098765 to
7429bf7
Compare
…nly tracks late spans that weren't sampled
jpkrohling
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Hello, I had to read through the
tailsamplingprocessor source code to understand how to tune and monitor the component. Here's some possible documentation to help others do the same