-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jsonlogencodingextension] Add Modes for Body with Attributes #32722
Merged
andrzej-stencel
merged 18 commits into
open-telemetry:main
from
blakeromano:pretty-json-encoding
May 7, 2024
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
b593b10
Pretty JSON Encoding
blakeromano 4df2efb
add change log info
blakeromano 3c10a1b
clean up tests and add documentation
blakeromano 3e39d70
Merge branch 'main' into pretty-json-encoding
blakeromano 1df0c69
address pr comments, fix linting
blakeromano be201e9
Merge branch 'pretty-json-encoding' of https://github.com/blakeromano…
blakeromano 3ea9ce6
Merge branch 'main' into pretty-json-encoding
blakeromano 697b6ab
remove unneeded function and update json key names
blakeromano ebb50df
Merge branch 'pretty-json-encoding' of https://github.com/blakeromano…
blakeromano 9dae95f
fix test and corresponding doc
blakeromano 9e1563a
small improvements
blakeromano 0a5aff8
Merge branch 'main' into pretty-json-encoding
blakeromano e2d4767
fix formatting
blakeromano c8bcfaa
Merge branch 'pretty-json-encoding' of https://github.com/blakeromano…
blakeromano 9f7da1e
Merge branch 'main' into pretty-json-encoding
blakeromano 25d66c6
doc updates and naming updates
blakeromano 375a495
Merge branch 'pretty-json-encoding' of https://github.com/blakeromano…
blakeromano 4c3edac
Merge branch 'main' into pretty-json-encoding
blakeromano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
# Use this changelog template to create an entry for release notes. | ||
|
||
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
change_type: enhancement | ||
|
||
# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver) | ||
component: jsonlogencodingextension | ||
|
||
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
note: "Adds a new encoding option for JSON log encoding exension to grab attributes and resources from a log and output that in JSON format." | ||
|
||
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. | ||
issues: [32679] | ||
|
||
# (Optional) One or more lines of additional information to render under the primary note. | ||
# These lines will be padded with 2 spaces and then inserted directly into the document. | ||
# Use pipe (|) for multiline entries. | ||
subtext: | ||
|
||
# If your change doesn't affect end users or the exported elements of any package, | ||
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label. | ||
# Optional: The change log or logs in which this entry should be included. | ||
# e.g. '[user]' or '[user, api]' | ||
# Include 'user' if the change is relevant to end users. | ||
# Include 'api' if there is a change to a library API. | ||
# Default: '[user]' | ||
change_logs: [user] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -11,4 +11,43 @@ | |||||
[development]: https://github.com/open-telemetry/opentelemetry-collector#development | ||||||
<!-- end autogenerated section --> | ||||||
|
||||||
The `jsonlog` encoding extension is used to marshal/unmarshal JSON log body, ignoring other log fields. | ||||||
## Configuration | ||||||
|
||||||
| Name | Description | Default | | ||||||
| ------------------------ | -------------------------------------------------- | -------------------------------------------- | | ||||||
| mode | What mode of the JSON encoding extension you want | body | | ||||||
|
||||||
|
||||||
|
||||||
### Mode | ||||||
|
||||||
#### body Mode | ||||||
|
||||||
The `body` mode of the JSON encoding extension is used to marshal or unmarshal the JSON log body, ignoring other log fields. | ||||||
|
||||||
|
||||||
#### body_with_inline_attributes | ||||||
|
||||||
The `body_with_inline_attributes` mode within the JSON encoding extension grabs the resource and attributes and adds them as key value pairs to the JSON body. It iterates through all the logs and creates a JSON array like the following example: | ||||||
|
||||||
```json | ||||||
[ | ||||||
{ | ||||||
"body": { | ||||||
"log": "test" | ||||||
}, | ||||||
"resourceAttributes": { | ||||||
"test": "logs-test" | ||||||
}, | ||||||
"logAttributes": { | ||||||
"foo": "bar" | ||||||
} | ||||||
}, | ||||||
{ | ||||||
"body": "log testing", | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should be
Suggested change
|
||||||
"resource": { | ||||||
"test": "logs-test" | ||||||
} | ||||||
} | ||||||
] | ||||||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to make the headings consistent