WIP: [translator/prometheusremotewrite] Expose PrometheusConverter type, with generated implementation #32665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknuds1
changed the title
github-actions
bot
requested review from
Aneurysm9,
bertysentry,
dashpole and
rapphil
aknuds1
force-pushed
the
arve/prometheusremotewrite-pluggable
branch
from
e7aeb23
to
6c66a68
Compare
aknuds1
force-pushed
the
arve/prometheusremotewrite-pluggable
branch
10 times, most recently
from
5142d4c
to
c4a6cbb
Compare
…d implementation. Signed-off-by: Arve Knudsen <[email protected]>
aknuds1
force-pushed
the
arve/prometheusremotewrite-pluggable
branch
from
c4a6cbb
to
7751d5f
Compare
|
Closing since I've found a better approach, see comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Expose the
PrometheusConvertertype frompkg/translator/prometheusremotewrite(previosly hidden behind the wrappingFromMetricsfunction), and generate thePrometheusConverter.FromMetricsimplementation from templates. This approach lets Prometheus compatible systems such as Grafana Mimir, Thanos, Cortex etc. generate translation code for their own target format.Also use the
PrometheusConvertertype fromexporter/prometheusremotewriteexporter, to avoid the overhead of unnecessary translation inprometheusremotewrite.FromMetrics.Link to tracking Issue: #32666
Testing:
I've benchmarked, the results are: TODO
Documentation: