[chore] vcenterreceiver Updates Scraper Tests To Represent More Diverse Environment #32607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanKurek
force-pushed
the
chore/vcenterreceiver-update-scraper-tests
branch
4 times, most recently
from
6f32105 to
607bcc3
Compare
StefanKurek
force-pushed
the
chore/vcenterreceiver-update-scraper-tests
branch
2 times, most recently
from
7aedbbb to
6e01de5
Compare
djaglowski
approved these changes
Apr 23, 2024
|
Waiting on #32639 to resolve CI failures |
StefanKurek
force-pushed
the
chore/vcenterreceiver-update-scraper-tests
branch
from
b426bc2 to
42ec3b6
Compare
StefanKurek
force-pushed
the
chore/vcenterreceiver-update-scraper-tests
branch
from
42ec3b6 to
616a368
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
No user facing changes.
Updated the scraper unit tests of the vcenterreceiver to represent a more interesting environment (Multiple hosts, multiple VMs, a vApp). This will change the expected results, but will also highlight some of the odd issues that I've been noticing (and hopefully will make future PRs to fix some of these issues a little more painless).
Also cleaned up the mock server and XML response files in general so they were a little easier to follow.
Link to tracking Issue:
N/A
Testing:
Unit tests passing with updated (but expected) results.
Documentation:
None needed.