sumologicexporter: refactor sender #32592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
aboguszewski-sumo,
kasia-kujawa,
mat-rumian,
rnishtala-sumo and
swiatekm
added 2 commits
April 22, 2024 11:08
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
sumo-drosiek
force-pushed
the
drosiek-refactor-sender
branch
from
25cc5e8 to
968b791
Compare
Signed-off-by: Dominik Rosiek <[email protected]>
swiatekm
approved these changes
Apr 22, 2024
mx-psi
reviewed
Apr 23, 2024
I confirm. The only change visible for users is log: before: |
mx-psi
approved these changes
Apr 23, 2024
|
Looks like this leads to test failures: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/8800270788/job/24151351338 |
djaglowski
pushed a commit
that referenced
this pull request
Apr 23, 2024
|
@sumo-drosiek This was reverted by #32639 |
|
I'll look at it 😕 |
mx-psi
added a commit
that referenced
this pull request
Apr 24, 2024
**Description:** Refactor sender in order to prepare for adding OTLP formats Reduces size of #32315 Reopens #32592 due to revert due to test issues **Link to tracking Issue:** #31479 **Testing:** Minimal changes to unit tests to ensure that everything works like before **Documentation:** N/A --------- Signed-off-by: Dominik Rosiek <[email protected]> Co-authored-by: Pablo Baeyens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Refactor sender in order to prepare for adding OTLP formats
Reduces size of #32315
Link to tracking Issue: #31479
Testing:
Minimal changes to unit tests to ensure that everything works like before
Documentation:
N/A