[chore] add "Seeking codeowners" to Windows Performance Counters receiver #32576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iver Based on a message from @dashpole on CNCF Slack https://cloud-native.slack.com/archives/C01N6P7KR6W/p1713448144169939?thread_ts=1713439927.384819&cid=C01N6P7KR6W. > We should probably find a new owner for the windows perf counter receiver.
songy23
approved these changes
Apr 22, 2024
|
cc @braydonk |
crobert-1
approved these changes
Apr 22, 2024
|
As discussed on Slack, I have sought (and received) approval from my employment to pursue code ownership for the component. Assuming there is still a need for code owners, I would be willing to contribute some of my time to become one. I am not a member of the OpenTelemetry org yet, and I will be following the process outlined in the doc. If there is anything else that I should do/be doing, please let me know. Thanks, |
atoulme
approved these changes
Apr 22, 2024
codeboten
approved these changes
Apr 23, 2024
|
Thanks @alxbl! Becoming a member and then opening a PR to add yourself as a code owner would be great! |
This was referenced Apr 24, 2024
codeboten
pushed a commit
that referenced
this pull request
Apr 30, 2024
**Description:** Adding myself as a code owner for both `pkg/windowsperfcounters` and `receiver/windowsperfcounters` since we're currently working with those two a lot and will likely have more fixes/contributions coming in the next couple of months. I wasn't sure about the `pkg`, so if there are objections to that, I can do it in a later PR. **Link to tracking Issue:** Follow up on #32576
andrzej-stencel
deleted the
add-seeking-codeowners-to-windowsperfcounters-receiver
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a message from @dashpole on CNCF Slack.