[chore][receiver/awscontainerinsights] Enable goleak checks #32404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failed test is frequency of #32391, I've added a reference there. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Failing integration test is frequency of #33094, unrelated to this change. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This was referenced Jun 10, 2024
MovieStoreGuy
approved these changes
Jun 18, 2024
This was referenced Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Enable
goleakchecks on thecadvisorpackage of the AWS Container Insights receiver to help ensure no goroutines are being leaked.Link to tracking Issue:
#30438
Testing:
This package is a linux-only package, so I wasn't able to test locally, but CI/CD tests are passing.