-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sumologicexporter: use Sumo Logic Extension for authentication and to obtain endpoint #32383
Merged
andrzej-stencel
merged 11 commits into
open-telemetry:main
from
sumo-drosiek:drosiek-exporter-extension
Apr 17, 2024
Merged
sumologicexporter: use Sumo Logic Extension for authentication and to obtain endpoint #32383
andrzej-stencel
merged 11 commits into
open-telemetry:main
from
sumo-drosiek:drosiek-exporter-extension
Apr 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumo-drosiek
force-pushed
the
drosiek-exporter-extension
branch
5 times, most recently
from
April 16, 2024 09:56
0f0b30e
to
ed6f5bf
Compare
This PR adds functionality which doesn't work as is dedicated for OTLP format, but next PRs I'm going to add the following (if possible to split them):
|
sumo-drosiek
force-pushed
the
drosiek-exporter-extension
branch
from
April 16, 2024 10:45
ed6f5bf
to
d571a8c
Compare
sumo-drosiek
force-pushed
the
drosiek-exporter-extension
branch
from
April 16, 2024 12:23
5cd0712
to
ae24aa3
Compare
cc: @astencel-sumo @swiatekm-sumo |
sumo-drosiek
force-pushed
the
drosiek-exporter-extension
branch
2 times, most recently
from
April 16, 2024 15:35
0be6bb2
to
0199fe2
Compare
swiatekm
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one minor nitpick.
sumo-drosiek
commented
Apr 16, 2024
sumo-drosiek
force-pushed
the
drosiek-exporter-extension
branch
from
April 16, 2024 17:06
9de170f
to
398aae8
Compare
… obtain endpoint Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
sumo-drosiek
force-pushed
the
drosiek-exporter-extension
branch
from
April 17, 2024 04:19
398aae8
to
5f91948
Compare
github-actions
bot
requested review from
aboguszewski-sumo,
kasia-kujawa,
mat-rumian and
rnishtala-sumo
April 17, 2024 04:20
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
sumo-drosiek
force-pushed
the
drosiek-exporter-extension
branch
from
April 17, 2024 10:52
48a17d1
to
910fe68
Compare
andrzej-stencel
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Use Sumo Logic Extension for authentication and to obtain the endpoint. This is part of #31479 to make #32315 smaller, therefore it may have some unused code (like
getSignalURL
). Also OTLP format is not supported yet for neither of the formatsIt also partially fixes #32375 (partially because as long as there is no a otlp support, data won't be pushed to Sumo Logic)
Link to tracking Issue: #31479
Testing:
Documentation: