-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] update codecov action to v4 #32260
[CI] update codecov action to v4 #32260
Conversation
9d4d391
to
ccf2de0
Compare
It looks like to add support for v4 we'd need to add a token for this action. (v4 breaking change reference.)
|
Well it looks like the action actually passed here. I admit I'm a bit confused as to what's going on. I see from the output:
So maybe it did pick up your changes, but it's not requiring a token since the PR is a fork? But if this gets merged |
ccf2de0
to
9e87cef
Compare
@crobert-1 I wasn't sure if token is required for this repo seeing this information
but definitely it is better to add this. I need a help with adding the secret with token for this repo, link to the instruction for generating token is here. |
9e87cef
to
9f5596d
Compare
As this is closed open-telemetry/community#1926 so I expect that the |
9f5596d
to
c225586
Compare
Description: update codecov action to v4
Link to tracking Issue: #32259