Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] update codecov action to v4 #32260

Merged

Conversation

kasia-kujawa
Copy link
Contributor

Description: update codecov action to v4

Link to tracking Issue: #32259

@kasia-kujawa kasia-kujawa force-pushed the kkujawa_update_codecov branch 6 times, most recently from 9d4d391 to ccf2de0 Compare April 9, 2024 15:20
@crobert-1
Copy link
Member

crobert-1 commented Apr 9, 2024

It looks like to add support for v4 we'd need to add a token for this action. (v4 breaking change reference.)

Workflow changes unfortunately aren't picked up in their respective PR, so this failure wouldn't be hit until this gets merged into main, from my understanding. Some workflow changes aren't picked up (like CODEOWNERS), but this one appears to be.

@crobert-1 crobert-1 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 9, 2024
@crobert-1
Copy link
Member

Well it looks like the action actually passed here. I admit I'm a bit confused as to what's going on. I see from the output:

info - 2024-04-09 15:49:49,207 -- The PR is happening in a forked repo. Using tokenless upload.

So maybe it did pick up your changes, but it's not requiring a token since the PR is a fork? But if this gets merged main will fail with the token error, perhaps?

@kasia-kujawa kasia-kujawa force-pushed the kkujawa_update_codecov branch from ccf2de0 to 9e87cef Compare April 10, 2024 08:12
@kasia-kujawa kasia-kujawa marked this pull request as ready for review April 10, 2024 08:13
@kasia-kujawa kasia-kujawa requested review from a team and evan-bradley April 10, 2024 08:13
@kasia-kujawa
Copy link
Contributor Author

Well it looks like the action actually passed here. I admit I'm a bit confused as to what's going on. I see from the output:
info - 2024-04-09 15:49:49,207 -- The PR is happening in a forked repo. Using tokenless upload.
So maybe it did pick up your changes, but it's not requiring a token since the PR is a fork? But if this gets merged main will fail with the token error, perhaps?

@crobert-1 I wasn't sure if token is required for this repo seeing this information

PRs made from forks to the upstream public repos will support tokenless (e.g. contributors to OS projects do not need the upstream repo's Codecov token)

but definitely it is better to add this.

I need a help with adding the secret with token for this repo, link to the instruction for generating token is here.

@kasia-kujawa kasia-kujawa force-pushed the kkujawa_update_codecov branch from 9e87cef to 9f5596d Compare April 10, 2024 08:31
@kasia-kujawa
Copy link
Contributor Author

kasia-kujawa commented Apr 10, 2024

As this is closed open-telemetry/community#1926 so I expect that the CODECOV_TOKEN secret exists

@kasia-kujawa kasia-kujawa force-pushed the kkujawa_update_codecov branch from 9f5596d to c225586 Compare April 10, 2024 08:55
@andrzej-stencel andrzej-stencel merged commit 45fb967 into open-telemetry:main Apr 10, 2024
170 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants