Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc to v0.50.0 - abandoned #32254

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 9, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.49.0 -> v0.50.0 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Configuration

📅 Schedule: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team April 9, 2024 12:14
@renovate renovate bot added dependencies Pull requests that update a dependency file renovatebot labels Apr 9, 2024
@renovate renovate bot requested a review from codeboten April 9, 2024 12:14
@renovate renovate bot requested review from mx-psi and dmitryax as code owners April 9, 2024 12:21
@mx-psi mx-psi closed this Apr 9, 2024
@mx-psi mx-psi reopened this Apr 9, 2024
mx-psi
mx-psi previously approved these changes Apr 9, 2024
@mx-psi mx-psi dismissed their stale review April 9, 2024 15:45

Breaking changes

@mx-psi
Copy link
Member

mx-psi commented Apr 9, 2024

OpenTelemetry Go does not follow semver (see open-telemetry/opentelemetry-go/issues/3277) which causes issues here:

Error: /home/runner/go/pkg/mod/go.opentelemetry.io/otel/[email protected]/trace/span.go:165:20: cannot use (*recordingSpan)(nil) (value of type *recordingSpan) as ReadWriteSpan value in variable declaration: *recordingSpan does not implement ReadWriteSpan (missing method AddLink)
		have addLink("go.opentelemetry.io/otel/trace".Link)
		want AddLink("go.opentelemetry.io/otel/trace".Link)
Error: /home/runner/go/pkg/mod/go.opentelemetry.io/otel/[email protected]/trace/span.go:804:20: cannot use nonRecordingSpan{} (value of type nonRecordingSpan) as "go.opentelemetry.io/otel/trace".Span value in variable declaration: nonRecordingSpan does not implement "go.opentelemetry.io/otel/trace".Span (missing method AddLink)
Error: /home/runner/go/pkg/mod/go.opentelemetry.io/otel/[email protected]/trace/tracer.go:50:21: impossible type assertion: p.(*recordingSpan)
	*recordingSpan does not implement "go.opentelemetry.io/otel/trace".Span (missing method AddLink)
		have addLink("go.opentelemetry.io/otel/trace".Link)
		want AddLink("go.opentelemetry.io/otel/trace".Link)
Error: /home/runner/go/pkg/mod/go.opentelemetry.io/otel/[email protected]/trace/tracer.go:1[20](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/8616606447/job/23614769494?pr=32254#step:11:21):10: cannot use tr.newNonRecordingSpan(sc) (value of type nonRecordingSpan) as "go.opentelemetry.io/otel/trace".Span value in return statement: nonRecordingSpan does not implement "go.opentelemetry.io/otel/trace".Span (missing method AddLink)
Error: /home/runner/go/pkg/mod/go.opentelemetry.io/otel/[email protected]/trace/tracer.go:1[22](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/8616606447/job/23614769494?pr=32254#step:11:23):9: cannot use tr.newRecordingSpan(psc, sc, name, samplingResult, config) (value of type *recordingSpan) as "go.opentelemetry.io/otel/trace".Span value in return statement: *recordingSpan does not implement "go.opentelemetry.io/otel/trace".Span (missing method AddLink)

@renovate renovate bot changed the title Update module go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc to v0.50.0 Update module go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc to v0.50.0 - abandoned Apr 16, 2024
Copy link
Contributor Author

renovate bot commented Apr 16, 2024

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

@codeboten
Copy link
Contributor

no longer needed

@codeboten codeboten closed this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file dependency issue receiver/opencensus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants