Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @ycombinator as codeowner for elasticsearchexporter #32171

Merged

Conversation

ycombinator
Copy link
Contributor

@ycombinator ycombinator commented Apr 4, 2024

Description:

This PR proposes adding @ycombinator as a codeowner for the elasticsearch exporter component, being an employee of Elastic and also meeting the codeowner requirements:

  1. Be a member of the OpenTelemetry organization.
  2. (Code Owner Discretion) It is best to have resolved an issue related to the component, contributed directly to the component, and/or review component PRs. How much interaction with the component is required before becoming a Code Owner is up to any existing Code Owners.

@ycombinator ycombinator requested review from a team and mx-psi April 4, 2024 16:43
@ycombinator
Copy link
Contributor Author

cc: @JaredTan95 as current codeowner of the elasticsearch exporter.

@songy23 songy23 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 4, 2024
Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a code owner is a bit more involved than this. You'll need to add your GitHub username to the active code owners section of the component's metadata.yaml. Then you can run make update-codeowners to make sure the component's README and the .github/CODEOWNERS file is updated properly.

@ycombinator
Copy link
Contributor Author

Thanks @crobert-1. I've made the changes to the elasticsearchexporter's metadata.yaml file in 6f11e12. However, when I then ran GITHUB_TOKEN=github_pat_XXXXXXX make update-codeowners (from the repo's root directory), I got the following error:

$  GITHUB_TOKEN=github_pat_XXXXXXX make update-codeowners
cd cmd/githubgen && go install .
githubgen
2024/04/04 10:46:06 codeowners are not members: BinaryFissionGames, Frapschen, JonathanWamsley, MovieStoreGuy, Mrod1598, RichieSams, StefanKurek, VihasMakwana, adrielp, ag-ramachandran, akats7, alexvanboxel, antonblock, armstrmi, atingchen, atoulme, avadhut123pisal, bertysentry, braydonk, bryan-aguilar, chrroberts-pure, codeboten, cparkins, cpheps, damemi, dashpole, dehaansa, dgoscn, eedorenko, erichsueh3, evan-bradley, fatsheep9146, fchikwekwe, gjanco, greatestusername, hickeyma, hughesjj, jacobmarble, jamesmoessis, jmacd, jsuereth, kentquirk, khyatigandhi6, kkujawa-sumo, kongluoxing, liustanley, mapno, mar4uk, marctc, martin-majlis-s1, matej-g, mcardy, mcube8, moh-osman3, mrsillydog, nslaughter, pavankrish123, pcwiese, pjanotti, portertech, povilasv, psx95, pxaws, qiansheng91, rapphil, rmfitzpatrick, rnishtala-sumo, rogercoll, samiura, schmikei, sh0rez, shabicheng, shalper2, sinkingpoint, smithclay, splunkericl, srprash, swiatekm-sumo, tamir-michaeli, tomaz-s1, varunraiko, wangzlei, ycombinator, yotamloe, zdaratom-s1
make: *** [gengithub] Error 1

@crobert-1
Copy link
Member

I got the following error:

It looks like you don't have a personal access token configured properly for this command to run. The link referenced has the workaround, you can essentially just run make generate instead (since you've already updated the CODEOWNERS file). 👍

@ycombinator
Copy link
Contributor Author

ycombinator commented Apr 4, 2024

Thanks again, @crobert-1. Yup, it was the PAT. I created a classic GH token with all the permissions and, with that, the make update-codeowners command worked. I've since deleted both tokens.

Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for being willing to help out here @ycombinator!

Once the original code owner approves we'll be able to merge 👍

@mx-psi mx-psi merged commit 3ab6693 into open-telemetry:main Apr 5, 2024
142 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 5, 2024
@ycombinator ycombinator deleted the codeowners-exporter-es-add-ycombinator branch April 25, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/elasticsearch Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Sending raw logs via Elasticsearch exporter when format option is set
7 participants