-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @ycombinator as codeowner for elasticsearchexporter #32171
Add @ycombinator as codeowner for elasticsearchexporter #32171
Conversation
cc: @JaredTan95 as current codeowner of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a code owner is a bit more involved than this. You'll need to add your GitHub username to the active code owners section of the component's metadata.yaml. Then you can run make update-codeowners
to make sure the component's README and the .github/CODEOWNERS
file is updated properly.
Thanks @crobert-1. I've made the changes to the
|
It looks like you don't have a personal access token configured properly for this command to run. The link referenced has the workaround, you can essentially just run |
Thanks again, @crobert-1. Yup, it was the PAT. I created a classic GH token with all the permissions and, with that, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for being willing to help out here @ycombinator!
Once the original code owner approves we'll be able to merge 👍
Description:
This PR proposes adding @ycombinator as a codeowner for the
elasticsearch
exporter component, being an employee of Elastic and also meeting the codeowner requirements:mapping.mode: raw
configuration option #29619mapping.mode: ecs
#31694 as follow up to [exporter/elasticsearch] handle ecs mode mapping #31553