-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
telemetrygen: Fix incorrect error in log line #31362
Merged
dmitryax
merged 5 commits into
open-telemetry:main
from
carsonip:fix-incorrect-trace-log-error
Feb 27, 2024
Merged
telemetrygen: Fix incorrect error in log line #31362
dmitryax
merged 5 commits into
open-telemetry:main
from
carsonip:fix-incorrect-trace-log-error
Feb 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
approved these changes
Feb 22, 2024
@carsonip mind adding a changelog? |
…pentelemetry-collector-contrib into fix-incorrect-trace-log-error
Done, thanks |
atoulme
added
the
ready to merge
Code review completed; ready to merge by maintainers
label
Feb 23, 2024
andrzej-stencel
approved these changes
Feb 26, 2024
This was referenced Feb 27, 2024
dmitryax
approved these changes
Feb 27, 2024
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
**Description:** Incorrect error is used in logger.Error within telemetrygen traces.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cmd/telemetrygen
telemetrygen command
ready to merge
Code review completed; ready to merge by maintainers
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Incorrect error is used in logger.Error within telemetrygen traces.
Link to tracking Issue:
Testing:
Documentation: