Support latest DogStatsD version #31296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jverce
force-pushed
the
feat/support-latest-dogstatsd
branch
from
8677e7f
to
2f2e048
Compare
dmitryax
reviewed
Feb 27, 2024
jverce
force-pushed
the
feat/support-latest-dogstatsd
branch
from
2f2e048
to
d57542f
Compare
* Support DogStatsD v1.2 by accepting metrics with container IDs * Support DogStatsD v1.3 by accepting metrics with timestamps * Add tests for the cases above * Improve readability in `statsd_parser_test.go` when calling `testStatsDMetric` * Add changelog entry
jverce
force-pushed
the
feat/support-latest-dogstatsd
branch
from
2a93ff4
to
0d034ca
Compare
jmacd
approved these changes
Feb 27, 2024
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
**Description:** * Support DogStatsD v1.2 by accepting metrics with container IDs * Support DogStatsD v1.3 by accepting metrics with timestamps * Add tests for the cases above * Improve readability in `statsd_parser_test.go` when calling `testStatsDMetric` * Add changelog entry **Link to tracking Issue:** open-telemetry#31295 **Testing:** 1. Added unit tests to validate that the new fields are accepted and interpreted correctly 2. Manual tests to verify that the metrics go through a collector pipeline. Notice the `container_id` attribute and the `Timestamp` field, which contains a custom value different from `StartTimestamp`: ``` ScopeMetrics #0 ScopeMetrics SchemaURL: InstrumentationScope otelcol/statsdreceiver 0.94.0-dev Metric #0 Descriptor: -> Name: workflow_execution.failure -> Description: -> Unit: -> DataType: Sum -> IsMonotonic: false -> AggregationTemporality: Delta NumberDataPoints #0 Data point attributes: -> container_id: Str(d69b8773f0ac1d93447a5835cb4ed1bf13dd336d32994830687ae1f352c86fe4) -> deployment.id: Str(d_0lBskd) -> metric_type: Str(counter) -> env: Str(development) -> project.id: Str(proj_kYRs18) -> trace.id: Str(2cQtSfsef2TN3EC2psGIorPaFd8) -> workflow.id: Str(p_0PACqQ) StartTimestamp: 2024-02-16 03:53:30.323425523 +0000 UTC Timestamp: 2024-02-16 03:53:51 +0000 UTC Value: 1 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
statsd_parser_test.gowhen callingtestStatsDMetricLink to tracking Issue: #31295
Testing:
container_idattribute and theTimestampfield, which contains a custom value different fromStartTimestamp:Documentation: No docs added