Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] remove toolchain directive #31224

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

codeboten
Copy link
Contributor

Unclear why these ended up here, removing them.

@bryan-aguilar
Copy link
Contributor

 cd /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/internal/tools && go build -o /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/.tools/builder -trimpath go.opentelemetry.io/collector/cmd/builder
/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/.tools/builder --skip-compilation --config cmd/otelcontribcol/builder-config.yaml --output-path cmd/otelcontribcol
Flag --output-path has been deprecated, use config distribution::output_path
2024-02-13T16:25:27.662Z	INFO	internal/command.go:123	OpenTelemetry Collector Builder	{"version": "", "date": "unknown"}
2024-02-13T16:25:27.666Z	INFO	internal/command.go:159	Using config file	{"path": "cmd/otelcontribcol/builder-config.yaml"}
2024-02-13T16:25:27.666Z	INFO	builder/config.go:109	Using go	{"go-executable": "/opt/hostedtoolcache/go/1.21.7/x64/bin/go"}
2024-02-13T16:25:27.667Z	INFO	builder/main.go:67	You're building a distribution with non-aligned version of the builder. Compilation may fail due to API changes. Please upgrade your builder or API	{"builder-version": "0.94.0"}
2024-02-13T16:25:27.674Z	INFO	builder/main.go:91	Sources created	{"path": "cmd/otelcontribcol"}
2024-02-13T16:25:27.674Z	INFO	builder/main.go:25	Running go subcommand.	{"arguments": ["get", "cloud.google.com/go"]}
2024-02-13T16:25:28.070Z	INFO	builder/main.go:25	Running go subcommand.	{"arguments": ["mod", "tidy", "-compat=1.20"]}
2024-02-13T16:25:28.606Z	INFO	builder/main.go:142	Getting go modules
2024-02-13T16:25:28.606Z	INFO	builder/main.go:25	Running go subcommand.	{"arguments": ["mod", "download"]}
2024-02-13T16:25:28.735Z	INFO	builder/main.go:98	Generating source codes only, the distribution will not be compiled.
make --no-print-directory -C cmd/otelcontribcol fmt
Makefile:4: warning: overriding recipe for target 'lint'
../../Makefile.Common:197: warning: ignoring old recipe for target 'lint'
cd /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/internal/tools && go build -o /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/.tools/goimports -trimpath golang.org/x/tools/cmd/goimports
gofmt  -w -s ./
/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/.tools/goimports -w  -local github.com/open-telemetry/opentelemetry-collector-contrib ./
Generated code is out of date, please run "make genotelcontribcol" and commit the changes in this PR.

@TylerHelmuth
Copy link
Member

@codeboten ready to rebase

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need another rebase

@atoulme atoulme force-pushed the codeboten/rm-toolchain branch from c495a7c to 66321f5 Compare February 16, 2024 23:27
@atoulme
Copy link
Contributor

atoulme commented Feb 16, 2024

rebased

@atoulme
Copy link
Contributor

atoulme commented Feb 18, 2024

It fails because the dependency on the builder is different from the rest of core, we need to update all of core dependencies.

@atoulme
Copy link
Contributor

atoulme commented Mar 1, 2024

Should this PR be closed?

@codeboten codeboten force-pushed the codeboten/rm-toolchain branch from a9e4b9f to a56a942 Compare March 1, 2024 22:57
@codeboten codeboten merged commit ad9eda5 into open-telemetry:main Mar 1, 2024
137 checks passed
@codeboten codeboten deleted the codeboten/rm-toolchain branch March 1, 2024 23:07
@github-actions github-actions bot added this to the next release milestone Mar 1, 2024
XinRanZhAWS pushed a commit to XinRanZhAWS/opentelemetry-collector-contrib that referenced this pull request Mar 13, 2024
Unclear why these ended up here, removing them.

Signed-off-by: Alex Boten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/configschema configschema command cmd/githubgen cmd/mdatagen mdatagen command cmd/opampsupervisor cmd/otelcontribcol otelcontribcol command cmd/oteltestbedcol cmd/telemetrygen telemetrygen command confmap/provider/s3provider confmap/provider/secretsmanagerprovider connector/count connector/datadog connector/exceptions connector/failover connector/routing connector/servicegraph connector/spanmetrics exporter/alertmanager exporter/alibabacloudlogservice Alibaba components exporter/awscloudwatchlogs awscloudwatchlogs exporter exporter/awsemf awsemf exporter exporter/awskinesis exporter/awss3 exporter/awsxray exporter/azuredataexplorer exporter/azuremonitor exporter/carbon exporter/cassandra exporter/clickhouse exporter/coralogix exporter/datadog Datadog components exporter/dataset exporter/dynatrace exporter/elasticsearch exporter/f5cloud F5 exporter exporter/file exporter/googlecloud exporter/googlecloudpubsub exporter/googlemanagedprometheus Google Managed Prometheus exporter exporter/honeycombmarker exporter/influxdb exporter/instana exporter/kafka exporter/kinetica exporter/loadbalancing exporter/logicmonitor exporter/logzio exporter/loki Loki Exporter exporter/mezmo exporter/opencensus exporter/opensearch exporter/otelarrow exporter/prometheus exporter/prometheusremotewrite exporter/pulsar exporter/sapm exporter/sentry exporter/signalfx exporter/skywalking exporter/splunkhec exporter/sumologic exporter/syslog exporter/tencentcloudlogservice exporter/zipkin extension/asapauth extension/awsproxy extension/basicauth extension/bearertokenauth extension/encoding extension/headerssetter extension/healthcheck Health Check Extension extension/httpforwarder extension/jaegerremotesampling extension/oauth2clientauth extension/observer extension/oidcauth extension/opamp extension/pprof extension/remotetap extension/sigv4auth extension/solarwindsapmsettings extension/storage extension/sumologic internal/aws internal/tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants