Move sarama initialization to scraper start method #3104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from create scraper to start scraper method
Codecov Report
@@ Coverage Diff @@
## main #3104 +/- ##
==========================================
+ Coverage 91.59% 91.62% +0.02%
==========================================
Files 486 486
Lines 23515 23525 +10
==========================================
+ Hits 21539 21554 +15
+ Misses 1469 1461 -8
- Partials 507 510 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Resolved |
jrcamp
reviewed
Apr 16, 2021
jrcamp
reviewed
Apr 19, 2021
jrcamp
approved these changes
Apr 20, 2021
jrcamp
approved these changes
Apr 20, 2021
|
@bogdandrutu it would be great to get this merged before the next release |
pmatyjasek-sumo
pushed a commit
to pmatyjasek-sumo/opentelemetry-collector-contrib
that referenced
this pull request
Apr 28, 2021
* move client and admin initialization from create scraper to start scraper method * update integration test * update integration err msg * fix client close before return * fix for comments * update CHANGELOG.md
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
Updates #3104 Signed-off-by: Bogdan Drutu <[email protected]>
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
Updates #3104 Signed-off-by: Bogdan Drutu [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: scrapers are updated to initialize sarama client and admin in
Startinstead of thecreateMetricsReceivermethod. This way, the receiver is immediately created (instead of contacting broker(s) first). If no brokers are reachable, the receiver will fail to start. refLink to tracking Issue:
Testing: Unit test and integration test updated.
Documentation: