Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 'service' by 'collector' on go.mod files #31

Merged

Conversation

pjanotti
Copy link
Contributor

This is needed to have the import paths using collector instead of service. Opportunistic fix: similar update to README.md.

This is needed to have the import paths using collector instead of service. Opportunistic fix: similar update to README.md.
Copy link
Contributor

@rghetia rghetia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pjanotti pjanotti merged commit bb95418 into open-telemetry:master Oct 21, 2019
@pjanotti pjanotti deleted the replace-service-with-collector branch October 21, 2019 16:59
mxiamxia referenced this pull request in mxiamxia/opentelemetry-collector-contrib Jul 22, 2020
* add resource to vmreceiver.

* add panic if resource detection fails.

* add sync.Once around resource detection.
ljmsc referenced this pull request in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
codeboten pushed a commit that referenced this pull request Nov 23, 2022
codeboten pushed a commit that referenced this pull request Nov 23, 2022
sky333999 added a commit to sky333999/opentelemetry-collector-contrib that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants