Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[internal/aws/proxy] adopt component.UseLocalHostAsDefaultHost feature gate #30987

Merged
merged 4 commits into from
Feb 1, 2024
Merged

[internal/aws/proxy] adopt component.UseLocalHostAsDefaultHost feature gate #30987

merged 4 commits into from
Feb 1, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Feb 1, 2024

Description:
internal/aws/proxy adopts component.UseLocalHostAsDefaultHost feature gate

Link to tracking Issue:
#30702

Fixes #30986

Documentation:
Updated docs.

@atoulme atoulme requested a review from Aneurysm9 as a code owner February 1, 2024 06:45
@atoulme atoulme requested a review from a team February 1, 2024 06:45
@github-actions github-actions bot requested a review from mxiamxia February 1, 2024 06:46
@atoulme atoulme added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 1, 2024
mx-psi
mx-psi reviewed Feb 1, 2024
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this warrants a docs update on receiver/awsxrayreceiver and extension/awsproxy (those seem to be the only users)

@mx-psi mx-psi added the release:blocker The issue must be resolved before cutting the next release label Feb 1, 2024
@mx-psi
Copy link
Member

mx-psi commented Feb 1, 2024

@atoulme would you mind fixing the docs? I am going to mark this and #30992 as release blockers since I want to get all the components using the feature gate in one go.

@mx-psi mx-psi linked an issue Feb 1, 2024 that may be closed by this pull request
[all] Use of component.UseLocalHostAsDefaultHost #30702
Closed
18 tasks
@atoulme
Copy link
Contributor Author

atoulme commented Feb 1, 2024

Looks like you just made the update. We are set.

@github-actions github-actions bot requested review from srprash and wangzlei February 1, 2024 16:19
@mx-psi mx-psi merged commit f12f0ad into open-telemetry:main Feb 1, 2024
127 of 129 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 1, 2024
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Feb 1, 2024
@atoulme @mx-psi @cparkins
[internal/aws/proxy] adopt component.UseLocalHostAsDefaultHost feat…
0879118 
…ure gate (open-telemetry#30987)

Description:
internal/aws/proxy adopts `component.UseLocalHostAsDefaultHost` feature
gate

Link to tracking Issue:

open-telemetry#30702

Fixes
open-telemetry#30986

Documentation:
Updated docs.

---------

Co-authored-by: Pablo Baeyens <[email protected]>
Co-authored-by: Pablo Baeyens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@mxiamxia mxiamxia Awaiting requested review from mxiamxia

@srprash srprash Awaiting requested review from srprash

@wangzlei wangzlei Awaiting requested review from wangzlei

Assignees

@codeboten codeboten

Labels
internal/aws receiver/awsxray release:blocker The issue must be resolved before cutting the next release Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.94.0
Development

Successfully merging this pull request may close these issues.

Use localhost feature gate on internal/aws/proxy [all] Use of component.UseLocalHostAsDefaultHost
3 participants
@atoulme @mx-psi @codeboten