Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/signalfx] signalfxreceiver adopts component.UseLocalHostAsDefaultHost feature gate #30906

Merged
merged 1 commit into from
Jan 31, 2024
Merged

[receiver/signalfx] signalfxreceiver adopts component.UseLocalHostAsDefaultHost feature gate #30906

merged 1 commit into from
Jan 31, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jan 31, 2024

Description:
signalfxreceiver adopts component.UseLocalHostAsDefaultHost feature gate

Link to tracking Issue:
#30702

Documentation:
Updated docs.

@atoulme atoulme requested a review from dmitryax as a code owner January 31, 2024 07:51
@atoulme atoulme requested a review from a team January 31, 2024 07:51
@atoulme atoulme added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 31, 2024
@mx-psi
Copy link
Member

mx-psi commented Jan 31, 2024 

signalfxreceiver/factory.go:13: File is not `gci`-ed with --skip-generated -s standard -s default -s prefix(github.com/open-telemetry/opentelemetry-collector-contrib) (gci)
	"github.com/open-telemetry/opentelemetry-collector-contrib/internal/common/localhostgate"
signalfxreceiver/factory.go:18: File is not `gci`-ed with --skip-generated -s standard -s default -s prefix(github.com/open-telemetry/opentelemetry-collector-contrib) (gci)

@atoulme atoulme force-pushed the localhost_signalfx branch from 37777c4 to 1c478b3 Compare January 31, 2024 16:57
@atoulme
Copy link
Contributor Author

atoulme commented Jan 31, 2024

@mx-psi ready for another look

@mx-psi mx-psi merged commit 6ea2340 into open-telemetry:main Jan 31, 2024
95 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 31, 2024
@mx-psi mx-psi mentioned this pull request Jan 31, 2024
Closed
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Feb 1, 2024
@atoulme @cparkins
[receiver/signalfx] signalfxreceiver adopts `component.UseLocalHostAs…
3b00072 
…DefaultHost` feature gate (open-telemetry#30906)

**Description:**
signalfxreceiver adopts `component.UseLocalHostAsDefaultHost` feature
gate

**Link to tracking Issue:**
open-telemetry#30702 

**Documentation:**
Updated docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

Assignees

@evan-bradley evan-bradley

Labels
receiver/signalfx Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.94.0
Development

Successfully merging this pull request may close these issues.
3 participants
@atoulme @mx-psi @evan-bradley