Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore][processor/spanmetrics] Remove albertteoh as codeowner #30815

Closed
wants to merge 1 commit into from
Closed

[chore][processor/spanmetrics] Remove albertteoh as codeowner #30815

wants to merge 1 commit into from

Conversation

albertteoh
Copy link
Contributor

Description:
Move @albertteoh to emeritus codeowner for both spanmetrics processor and connector.

Move albertteoh to emeritus
f517b9e 
Signed-off-by: Albert Teoh <[email protected]>
@albertteoh albertteoh requested review from a team and songy23 January 29, 2024 08:05
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

CLA Missing ID CLA Not Signed

@github-actions github-actions bot requested a review from portertech January 29, 2024 08:05
albertteoh
albertteoh commented Jan 29, 2024
View reviewed changes
connector/spanmetricsconnector/metadata.yaml
@@ -7,6 +7,7 @@ status:
distributions: [contrib, sumo, grafana, splunk, liatrio]
codeowners:
active: [portertech]
emeritus: [albertteoh]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed adding myself to emeritus for the connector.

@albertteoh
Copy link
Contributor Author

Odd that I'm asked to sign the EasyCLA doc, even though I'd done it already in the past. In any case, I've re-submitted it.

@albertteoh albertteoh mentioned this pull request Jan 29, 2024
Merged
@mx-psi
Copy link
Member

mx-psi commented Jan 29, 2024

Odd that I'm asked to sign the EasyCLA doc, even though I'd done it already in the past. In any case, I've re-submitted it.

Looks like on this PR you are using a different email: https://github.com/open-telemetry/opentelemetry-collector-contrib/commit/f517b9e4f6215acb26f66136bfd5c677bc351f70.patch from the one you used here https://github.com/open-telemetry/opentelemetry-collector-contrib/commit/f19ca805ed6b91bf56c73ccbafd114a324a03b0a.patch

codeboten
codeboten approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @albertteoh

@albertteoh albertteoh mentioned this pull request Jan 30, 2024
Merged
@albertteoh
Copy link
Contributor Author

Odd that I'm asked to sign the EasyCLA doc, even though I'd done it already in the past. In any case, I've re-submitted it.

Looks like on this PR you are using a different email: https://github.com/open-telemetry/opentelemetry-collector-contrib/commit/f517b9e4f6215acb26f66136bfd5c677bc351f70.patch from the one you used here https://github.com/open-telemetry/opentelemetry-collector-contrib/commit/f19ca805ed6b91bf56c73ccbafd114a324a03b0a.patch

Ah, yes, you're right @mx-psi, thanks!

I've recreated this PR in: #30859

Sorry folks!

@albertteoh albertteoh closed this Jan 30, 2024
@albertteoh albertteoh deleted the emeritus-albertteoh branch January 30, 2024 09:29
mx-psi added a commit that referenced this pull request Jan 31, 2024
@albertteoh @mx-psi
[chore][processor/spanmetrics] Remove albertteoh as codeowner (#30859)
cf09bb6 
**Description:** 

Move @albertteoh to emeritus codeowner for both spanmetrics processor
and connector.

Supersedes:
#30815

Signed-off-by: albertteoh <[email protected]>
Co-authored-by: Pablo Baeyens <[email protected]>
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Feb 1, 2024
@albertteoh @mx-psi @cparkins
[chore][processor/spanmetrics] Remove albertteoh as codeowner (open-t…
83a6d32 
…elemetry#30859)

**Description:** 

Move @albertteoh to emeritus codeowner for both spanmetrics processor
and connector.

Supersedes:
open-telemetry#30815

Signed-off-by: albertteoh <[email protected]>
Co-authored-by: Pablo Baeyens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobert-1 crobert-1 crobert-1 approved these changes

@songy23 songy23 songy23 approved these changes

@codeboten codeboten codeboten approved these changes

@portertech portertech Awaiting requested review from portertech

Assignees

@dashpole dashpole

Labels
connector/spanmetrics processor/spanmetrics Span Metrics processor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@albertteoh @mx-psi @codeboten @songy23 @crobert-1 @dashpole